Closed Bug 1862512 Opened 1 year ago Closed 1 year ago

cdm-test-storage.cpp: extra ';' after member function definition

Categories

(Core :: Audio/Video, task)

task

Tracking

()

RESOLVED FIXED
122 Branch
Tracking Status
firefox122 --- fixed

People

(Reporter: Sylvestre, Assigned: neel, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

Filling as a good first bug to learn workflows.

extra ';' after member function definition:
https://searchfox.org/mozilla-central/source/dom/media/fake-cdm/cdm-test-storage.cpp#187

As the change is trivial, it is just to learn how to contribute to Firefox.

https://clang.llvm.org/docs/DiagnosticsReference.html#wextra-semi

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Component: General → Audio/Video
Product: Toolkit → Core
Attachment #9365064 - Attachment description: Bug 1862512: cdm-test-storage.cpp: extra ';' after member function definition → Bug 1862512: Remove extra ';' after member function definition in cdm-test-storage.cpp
Assignee: nobody → neel
Status: NEW → ASSIGNED

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:neel, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(neel)
Flags: needinfo?(alwu)
Flags: needinfo?(neel)
Flags: needinfo?(alwu)
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e491a836d51a Remove extra ';' after member function definition in cdm-test-storage.cpp r=alwu
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: