Closed Bug 1862530 Opened 11 months ago Closed 10 months ago

Switch new arraybuffer-related APIs to mozilla::Span

Categories

(Core :: JavaScript Engine, task, P2)

task

Tracking

()

RESOLVED FIXED
121 Branch
Tracking Status
firefox121 --- fixed

People

(Reporter: sfink, Assigned: sfink)

Details

Attachments

(1 file)

The new APIs in js/public/experimental/TypedData.h have messy functions like getLengthAndData() and a redundant getData() that discards the length. The DOM bindings consumer wraps the output in mozilla::Span, which seems rather preferable.

Note that the functions still aren't pretty, due to the need to pass back an isShared flag to force the caller to Think Thoughts about whether to handled shared array buffer memory.

Assignee: nobody → sphink
Status: NEW → ASSIGNED
Severity: -- → S3
Priority: -- → P2
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/da66512275d0
Switch to using mozilla::Span in typed array getLengthAndData functions and merge getLengthAndData,getData -> getData. r=spidermonkey-reviewers,jandem
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
Regressions: 1866518
No longer regressions: 1866518
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: