1862583 - Selected tab color can lag behind when switching tabs, due to async tab switching and tabs.css using [selected] instead of [visuallyselected]

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dão Gottwald [:dao]]

Looks like this has been broken for some time. The selected attribute is a bit of a footgun. :(

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1862583 - Use [visuallyselected] instead of [selected] to set the selected tab color. r=emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3084ddd8f59d
Use [visuallyselected] instead of [selected] to set the selected tab color. r=emilio,desktop-theme-reviewers

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for causing almost perma failures on test_ext_url_overrides_newtab.js

• backout: https://hg.mozilla.org/integration/autoland/rev/86b37d608b6dff619ef21dd6df25970d2f35504f
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=KCZWwoZLTuqc84ZUoyJ_TQ.0&revision=3084ddd8f59dc74d30cc1d310b3d1be20882f9e2
• failure log: https://treeherder.mozilla.org/logviewer?job_id=434666359&repo=autoland&lineNumber=3309

[task 2023-11-02T10:39:07.147Z] 10:39:07     INFO -  TEST-START | xpcshell.ini:browser/components/extensions/test/xpcshell/test_ext_url_overrides_newtab.js
[task 2023-11-02T10:44:07.149Z] 10:44:07  WARNING -  TEST-UNEXPECTED-TIMEOUT | xpcshell.ini:browser/components/extensions/test/xpcshell/test_ext_url_overrides_newtab.js | Test timed out
[task 2023-11-02T10:44:07.150Z] 10:44:07     INFO -  TEST-INFO took 300001ms
[task 2023-11-02T10:44:07.150Z] 10:44:07     INFO -  >>>>>>>
[task 2023-11-02T10:44:07.150Z] 10:44:07     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2023-11-02T10:44:07.150Z] 10:44:07     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2023-11-02T10:44:07.150Z] 10:44:07     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2023-11-02T10:44:07.150Z] 10:44:07     INFO -  running event loop
[task 2023-11-02T10:44:07.150Z] 10:44:07     INFO -  xpcshell.ini:browser/components/extensions/test/xpcshell/test_ext_url_overrides_newtab.js | Starting test_multiple_extensions_overriding_newtab_page
[task 2023-11-02T10:44:07.150Z] 10:44:07     INFO -  (xpcshell/head.js) | test test_multiple_extensions_overriding_newtab_page pending (2)
[task 2023-11-02T10:44:07.150Z] 10:44:07     INFO -  TEST-PASS | xpcshell.ini:browser/components/extensions/test/xpcshell/test_ext_url_overrides_newtab.js | test_multiple_extensions_overriding_newtab_page - [test_multiple_extensions_overriding_newtab_page : 147]

Comment 4

[Natalia Csoregi [:nataliaCs]]

Further investigation shows that this was not in fact, the issue.
Relanded the patch accordingly.
Sorry if this has caused any inconvenience!

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/994197aae5bf

Comment 6

[Andrej (:aglavic)]

== Change summary for alert #40111 (as of Sat, 04 Nov 2023 15:13:06 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
3%	tabswitch	windows10-64-shippable-qr	e10s fission stylo webrender-sw	8.12 -> 7.84
20%	perf_reftest_singletons id-getter-2.html	windows10-64-shippable-qr	e10s fission stylo webrender	639.66 -> 514.42

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40111
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40094