1862936 - Pinned tabs don't get closed by PBM reset action

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect, P2)

Description

[Emma Zühlcke [:emz]]

STR:

1. Open a new private window
2. Navigate to any website
3. Right click the current tab and select "Pin Tab"
4. Trigger the reset PBM action via toolbar button

Expected:
All tabs are closed and only a new about:privatebrowsing tab is opened

Actual:
The pinned tabs remains open

Comment 1

[Emma Zühlcke [:emz]]

Seems like a simple fix. We just need to add an option to the removeAllTabsBut methods to skip these checks. At that point it would make sense to move all option into aParams, even if they're not consumed in removeTabs.

Comment 2

[Emma Zühlcke [:emz]]

Attachment: Bug 1862936 - Add a flag to removeAllTabsBut for closing pinned and selected tabs. r=#tabbrowser!

Depends on D193069

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1eda7f37f458
Add a flag to removeAllTabsBut for closing pinned and selected tabs. r=tabbrowser-reviewers,dao

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/1eda7f37f458

Comment 5

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-11-03 Nightly build on Windows 10.
Verified as fixed on Firefox 121.0b3 and Nightly 122.0a1 on Windows 10, Ubuntu 22, macOS 12.