Closed Bug 1862937 Opened 9 months ago Closed 8 months ago

Add a profiler marker for LCP metric

Categories

(Core :: Gecko Profiler, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
121 Branch
Tracking Status
firefox121 --- fixed

People

(Reporter: canova, Assigned: canova)

References

Details

(Whiteboard: [fxp])

Attachments

(1 file)

We should have a marker for LCP metric so we can see it in the profiler frontend easily.

Whiteboard: [fxp]

There might be multiple LCP entries in a web page, and we only care about the
last one which is also the biggest value. That's why we need to record these
values in two different places:

  • During the Document unload, so we can add markers for the closed pages.
  • During the profile capture, so we can add markers for the open pages.

This allows us to capture all the LCP values. Note that this is not the case
for other metrics like FCP, TTFB, DOMContentLoaded etc. that fires only once.

Pushed by canaltinova@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/31f667310dfe
Add profiler markers for LCP values r=sefeng,profiler-reviewers,florian

Backed out for causing multiple failures in WeakPtr.h.


  • Push with failures- mochitests failures
  • Failure Log
  • Failure line: Assertion failure: !_owningThread || _owningThread->IsCurrentThread() (WeakPtr accessed from multiple threads), at /builds/worker/workspace/obj-build/dist/include/mozilla/WeakPtr.h:184

  • Push with failures - devtools failures
  • Failure Log
  • Failure line: Assertion failure: !_owningThread || _owningThread->IsCurrentThread() (WeakPtr accessed from multiple threads), at /builds/worker/workspace/obj-build/dist/include/mozilla/WeakPtr.h:184
Flags: needinfo?(canaltinova)
Pushed by canaltinova@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4100364d528c
Add profiler markers for LCP values r=sefeng,profiler-reviewers,florian
Pushed by canaltinova@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a54c3ee7f62b
Add profiler markers for LCP values r=sefeng,profiler-reviewers,florian,emilio
Flags: needinfo?(canaltinova)
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
Regressions: 1864543
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: