Closed Bug 1862944 Opened 3 years ago Closed 3 years ago

Perma Windows [tier 2] TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/unit/test_unitConversion.js | xpcshell return code: 0

Categories

(Firefox :: Address Bar, defect, P5)

defect

Tracking

()

RESOLVED FIXED
121 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox119 --- unaffected
firefox120 --- unaffected
firefox121 --- fixed

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Regression)

Details

(Keywords: intermittent-failure, intermittent-testcase, regression)

Filed by: sstanca [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=434815811&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/UHMltwaIQ1agl6vFiqjuDw/runs/0/artifacts/public/logs/live_backing.log


[task 2023-11-03T11:28:09.275Z] 11:28:09     INFO -  TEST-PASS | toolkit/xre/test/test_launch_without_hang.js | took 5014ms
[task 2023-11-03T11:28:09.284Z] 11:28:09     INFO -  Retrying tests that failed when run in parallel.
[task 2023-11-03T11:28:09.286Z] 11:28:09     INFO -  TEST-START | browser/components/urlbar/tests/unit/test_unitConversion.js
[task 2023-11-03T11:28:10.047Z] 11:28:10  WARNING -  TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/unit/test_unitConversion.js | xpcshell return code: 0
[task 2023-11-03T11:28:10.056Z] 11:28:10     INFO -  TEST-INFO took 761ms
[task 2023-11-03T11:28:10.056Z] 11:28:10     INFO -  >>>>>>>
[task 2023-11-03T11:28:10.056Z] 11:28:10     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2023-11-03T11:28:10.056Z] 11:28:10     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2023-11-03T11:28:10.056Z] 11:28:10     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2023-11-03T11:28:10.056Z] 11:28:10     INFO -  running event loop
[task 2023-11-03T11:28:10.056Z] 11:28:10     INFO -  browser/components/urlbar/tests/unit/test_unitConversion.js | Starting
[task 2023-11-03T11:28:10.056Z] 11:28:10     INFO -  (xpcshell/head.js) | test pending (2)
[task 2023-11-03T11:28:10.057Z] 11:28:10     INFO -  "Test "1 d to d" in angle"
[task 2023-11-03T11:28:10.057Z] 11:28:10     INFO -  "Creating new queryContext with searchString: 1 d to d"
[task 2023-11-03T11:28:10.057Z] 11:28:10     INFO -  TEST-PASS | browser/components/urlbar/tests/unit/test_unitConversion.js |  - true == true

From backfills and retriggers it looks like it all started once Bug 1858854 was landed on autoland.

Hello Vinny! Could you please take a look at this?

Thank you!

Flags: needinfo?(vinny.diehl)
Keywords: regression
Regressed by: 1858854

Looks like we caught an invalid time zone getting set here. On the SM side we exclude Windows from tests involving setTimeZone because it breaks on some inputs. It's getting the string "Coordinated Universal Time" from getTimeZone which setTimeZone will no longer accept. arai, do you know if it should accept this on Windows? Should we disable the test or is there more work to make the validation platform dependant?

We can back out bug 1858854, I'll look into this when I'm back at my computer.

Flags: needinfo?(vinny.diehl) → needinfo?(arai.unmht)

Thank you for investigating the issue.
So, the code is restoring the time zone to the original value retrieved by getTimeZone, just as a cleanup after single test.

we could do one of the following:

  • (a) add restoreTimeZone function that does the same thing as setTimeZone, except for the validation
  • (b) add extra parameter to setTimeZone to suppress the validation for restoration purpose, such as setTimeZone(originalTimeZone, { skipValidation: true })
  • (c) Save the time zone string retrieved inside getTimeZone, and add it to allow list for setTimeZone

I think (a) is the simplest, and it's sufficient for the purpose, and also hard to misuse.

Flags: needinfo?(arai.unmht)

Closing this as bug 1858854 was backed out; link here.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
You need to log in before you can comment on or make changes to this bug.