1863116 - [flatpak] Remove org.freedesktop.Notifications permission from flatpak

Status: RESOLVED FIXED

(Firefox Build System :: Third Party Packaging, defect)

Description

[bbhtt]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:121.0) Gecko/20100101 Firefox/121.0

Steps to reproduce:

This permission https://hg.mozilla.org/mozilla-central/file/tip/taskcluster/docker/firefox-flatpak/runme.sh#l177 is no longer necessary as the Firefox baseapp comes with libnotify >= 0.8.0 https://github.com/flathub/org.mozilla.firefox.BaseApp/blob/8c691648cb9f87b5378c57cd73862a92f8b1c96a/org.mozilla.firefox.BaseApp.json#L63

libnotify automatically uses the portal https://flatpak.github.io/xdg-desktop-portal/docs/#gdbus-org.freedesktop.portal.Notification for notifications when run inside snap or flatpak since 0.8.0 https://gitlab.gnome.org/GNOME/libnotify/-/blob/69aff6e5fa2842e00b409c348bd73188548828b3/NEWS#L25

This permission is unused.

Comment 1

[bbhtt]

I can confirm it works when run with flatpak run --no-talk-name=org.freedesktop.Notifications org.mozilla.firefox, then going to https://www.bennish.net/web-notifications.html and triggering a desktop notification (Fedora 39/GNOME 45). I did the same change for the nightly flatpak I maintain https://gitlab.com/projects261/firefox-nightly-flatpak/-/commit/fd64baaa87cca73698f4a80d1d2587e86f02d3ae

Comment 2

[bbhtt]

Attachment: Bug 1863116 - Remove org.freedesktop.Notifications permission from flatpak. r?jcristau,stransky

This permission is no longer necessary as the Firefox baseapp comes with
libnotify >= 0.8.0 https://github.com/flathub/org.mozilla.firefox.BaseApp/blob/8c691648cb9f87b5378c57cd73862a92f8b1c96a/org.mozilla.firefox.BaseApp.json#L63

libnotify automatically uses the portal https://flatpak.github.io/xdg-desktop-portal/docs/#gdbus-org.freedesktop.portal.Notification
for notifications when run inside snap or flatpak since 0.8.0
https://gitlab.gnome.org/GNOME/libnotify/-/blob/69aff6e5fa2842e00b409c348bd73188548828b3/NEWS#L25

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2cf1b902ea75
Remove org.freedesktop.Notifications permission from flatpak. r=stransky

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/2cf1b902ea75