Closed Bug 1863226 Opened 2 years ago Closed 2 years ago

garbled playback of audio files saved in R

Categories

(Core :: Audio/Video: Playback, defect)

Product:
Core
Component:
Audio/Video: Playback
Version:
Firefox 118
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
121 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox119 --- wontfix
firefox120 --- wontfix
firefox121 --- fixed

People

(Reporter: rty_anik, Assigned: padenot)

References

(Regression)

Details

(Keywords: regression)

Attachments

(4 files, 9 obsolete files)

Bug 1863226 - Allow logging TrackInfo, AudioInfo. r?alwu
48 bytes, text/x-phabricator-request
Details | Review
Bug 1863226 - Add a logging statement when successfully initializing a WavDemuxer. r?alwu
48 bytes, text/x-phabricator-request
Details | Review
Bug 1863226 - Correctly demux wav files with WAVEFORMATEXTENSIBLE. r?alwu
48 bytes, text/x-phabricator-request
Details | Review
Bug 1863226 - Add a test with a WAV file with WAVEFORMATEXTENSIBLE. r?alwu
48 bytes, text/x-phabricator-request
Details | Review

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/118.0

Steps to reproduce:

Firefox 118 and above no longer plays correctly plain WAV files exported from R. This used to work fine in older versions, and it works in Chrome. Demo here: https://cogsci.se/javascript_audio_trouble/demo.html

Actual results:

The audio is garbled

Expected results:

Normal audio playback

The Bugbug bot thinks this bug should belong to the 'Core::Audio/Video: Playback' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Audio/Video: Playback
Product: Firefox → Core

Can repro.

Regression range :
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d1fbe6c1f87656fb4f55677904f55f6df433ea9a&tochange=e78e15a11c7c9c583172c6dc65f25fc847c46f5f

Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(padenot)
Assignee: nobody → padenot
Status: NEW → ASSIGNED

In particular this test would fail because we'd render multiple channels.

Depends on D192849

Pushed by padenot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/27ffb52ae374 Allow logging TrackInfo, AudioInfo. r=azebrowski https://hg.mozilla.org/integration/autoland/rev/80e17185c4f2 Add a logging statement when successfully initializing a WavDemuxer. r=azebrowski https://hg.mozilla.org/integration/autoland/rev/287dd43afc17 Correctly demux wav files with WAVEFORMATEXTENSIBLE. r=azebrowski https://hg.mozilla.org/integration/autoland/rev/dde9233b385d Add a test with a WAV file with WAVEFORMATEXTENSIBLE. r=azebrowski

Setting the affected versions based on the pushlog in Comment 2.
:padenot could you set the correct regressor? There are audio related bugs in that pushlog, I wasn't sure which one to set

status-firefox119: --- → wontfix
status-firefox120: --- → affected
status-firefox121: --- → affected
status-firefox-esr115: --- → unaffected
Keywords: regression

This is correct, thanks!

Flags: needinfo?(padenot)
Regressed by: 1826382

Backed out for causing build bustages in MediaData.cpp.

Flags: needinfo?(padenot)
Pushed by padenot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c9cb1201b67d Allow logging TrackInfo, AudioInfo. r=azebrowski https://hg.mozilla.org/integration/autoland/rev/3f25422c8417 Add a logging statement when successfully initializing a WavDemuxer. r=azebrowski https://hg.mozilla.org/integration/autoland/rev/52bbc1e8e40e Correctly demux wav files with WAVEFORMATEXTENSIBLE. r=azebrowski https://hg.mozilla.org/integration/autoland/rev/30015f974939 Add a test with a WAV file with WAVEFORMATEXTENSIBLE. r=azebrowski

:padenot can you set the priority/severity?

Flags: in-testsuite+
Attachment #9363882 - Flags: approval-mozilla-beta?
Attachment #9363883 - Flags: approval-mozilla-beta?
Attachment #9363884 - Flags: approval-mozilla-beta?

In particular this test would fail because we'd render multiple channels.

Original Revision: https://phabricator.services.mozilla.com/D192850

Attachment #9363885 - Flags: approval-mozilla-beta?

Uplift Approval Request

  • User impact if declined: Content breakage: audio files not rendered correctly
  • Risk associated with taking this patch: Non-existent
  • Steps to reproduce for manual QE testing: none
  • Explanation of risk level: Simple problem + fix, well tested
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Code covered by automated testing: yes
  • Is Android affected?: yes
  • String changes made/needed: none
Attachment #9363887 - Flags: approval-mozilla-release?
Attachment #9363887 - Attachment is obsolete: true
Flags: needinfo?(padenot)
Attachment #9363887 - Flags: approval-mozilla-release?

Uplift Approval Request

  • Code covered by automated testing: yes
  • Steps to reproduce for manual QE testing: none
  • Risk associated with taking this patch: Non-existent
  • Needs manual QE test: no
  • Is Android affected?: yes
  • Fix verified in Nightly: yes
  • User impact if declined: Content breakage: some audio files aren't rendered correctly
  • String changes made/needed: none
  • Explanation of risk level: Clear problem and fix, well tested
Attachment #9363889 - Flags: approval-mozilla-release?
Attachment #9363890 - Flags: approval-mozilla-release?
Attachment #9363891 - Flags: approval-mozilla-release?

In particular this test would fail because we'd render multiple channels.

Original Revision: https://phabricator.services.mozilla.com/D192850

Attachment #9363892 - Flags: approval-mozilla-release?

Uplift Approval Request

  • User impact if declined: Content rendering issue: some audio files rendering is broken
  • String changes made/needed: none
  • Explanation of risk level: Simple problem + fix, unit-tested, verified manually by the reviewer
  • Code covered by automated testing: yes
  • Steps to reproduce for manual QE testing: --
  • Risk associated with taking this patch: Non-existent
  • Needs manual QE test: no
  • Fix verified in Nightly: yes
  • Is Android affected?: yes
Attachment #9363882 - Attachment is obsolete: true
Attachment #9363882 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Attachment #9363883 - Attachment is obsolete: true
Attachment #9363883 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Attachment #9363884 - Attachment is obsolete: true
Attachment #9363884 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Attachment #9363885 - Attachment is obsolete: true
Attachment #9363885 - Flags: approval-mozilla-beta? → approval-mozilla-beta-

Comment on attachment 9363889 [details]
Bug 1863226 - Allow logging TrackInfo, AudioInfo. r?alwu

Approved for 120.0.1 dot release

Attachment #9363889 - Flags: approval-mozilla-release? → approval-mozilla-release+
Attachment #9363890 - Flags: approval-mozilla-release? → approval-mozilla-release+
Attachment #9363891 - Flags: approval-mozilla-release? → approval-mozilla-release+
Attachment #9363892 - Flags: approval-mozilla-release? → approval-mozilla-release+

Comment on attachment 9363889 [details]
Bug 1863226 - Allow logging TrackInfo, AudioInfo. r?alwu

backed out

Attachment #9363889 - Flags: approval-mozilla-release+ → approval-mozilla-release-
Attachment #9363890 - Flags: approval-mozilla-release+ → approval-mozilla-release-
Attachment #9363891 - Flags: approval-mozilla-release+ → approval-mozilla-release-
Attachment #9363892 - Flags: approval-mozilla-release+ → approval-mozilla-release-
Attachment #9363890 - Attachment is obsolete: true
Attachment #9363891 - Attachment is obsolete: true
Attachment #9363892 - Attachment is obsolete: true
Attachment #9363889 - Flags: approval-mozilla-release- → approval-mozilla-release?
Attachment #9363889 - Attachment is obsolete: true
Attachment #9363889 - Flags: approval-mozilla-release? → approval-mozilla-release-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: