1863250 - Services.clearData.deleteDataFromBaseDomain evicts unrelated cache entry

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect, P2)

Description

[6k64x4ma]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:120.0) Gecko/20100101 Firefox/120.0

Steps to reproduce:

1. Launch Firefox with a new profile.
2. Set devtools.chrome.enabled to true.
3. Browse for a while to add cache files (e.g. go to https://www.mozilla.org/en-US/firefox/developer/).
4. Load about:cache.
5. Run this snippet in the Browser Console.

Services.clearData.deleteDataFromBaseDomain(
  "test.invalid",
  false,
  Services.clearData.CLEAR_NETWORK_CACHE,
  { onDataDeleted: flags => console.log(flags) }
);

6. Wait until the process is complete.
7. Duplicate about:cache and compare the two.

Actual results:

• Many cache entries are evicted.

Expected results:

• No cache entries should be evicted since there are no entries loaded from test.invalid.

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9b2ffc8e850587f349301559d397a384ef5c7508&tochange=b9a82200b994f1d8c24f4cc2881b01f245c82757

Comment 1

[Harshit Sohaney [:hsohaney]]

I was able to reproduce this and am moving it to the correct component

Comment 2

[Kershaw Chang [:kershaw]]

I can't reproduce.

Reporter, could you try to record a http log for this?
Please set MOZ_LOG to timestamp,cache2:5 and also use a clean profile to reproduce.

Thanks.

Comment 3

[6k64x4ma]

Attachment: log.txt-main.9888.zip

Here you are. I recorded this using Nightly (Build ID: 20231116093942).

Comment 4

[Kershaw Chang [:kershaw]]

Thanks for the log.
It appears that when Services.clearData.deleteDataFromBaseDomain is called, we call clearBaseDomain. In clearBaseDomain, CacheFileIOManager::EvictByContext will be called with an empty origin and a base domain. Then, at the end of the function EvictByContextInternal, we create CacheFileContextEvictor to evict entries. Note that in CacheFileContextEvictor, the base domain is not used to check if the entry should be removed. This seems to be the root cause of this bug.

Comment 5

[Emma Zühlcke [:emz]]

Attachment: Bug 1863250 - Support for base domain filtering in CacheFileContextEvictor. r=#necko!

Comment 6

[Emma Zühlcke [:emz]]

Attachment: Bug 1863250 - Update on-disk eviction info logic to support base domain clearing. r=#necko!

Comment 7

[Emma Zühlcke [:emz]]

Attachment: Bug 1863250 - Test, r=#necko!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c12c68ce87f
Support for base domain filtering in CacheFileContextEvictor. r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/9dff877d4a91
Update on-disk eviction info logic to support base domain clearing. r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/2f9f1d5510d4
Test, r=necko-reviewers,valentin

Comment 9

[Atila Butkovits]

Backed out for causing failures at test_cache2-33-clear-base-domain.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/709aef2930d7de7f22e3f3543dba5e7796b27643

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=2f9f1d5510d4ca53a47d4e44a5320f609364aaaa&selectedTaskRun=RvU9zcAERby0pB8uSD3h0g.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=494966481&repo=autoland&lineNumber=4032

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c9a9c3a815c
Support for base domain filtering in CacheFileContextEvictor. r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/ff1d529f6ca5
Update on-disk eviction info logic to support base domain clearing. r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/cbbeb9a286aa
Test, r=necko-reviewers,valentin

Comment 11

[amarc]

https://hg.mozilla.org/mozilla-central/rev/6c9a9c3a815c
https://hg.mozilla.org/mozilla-central/rev/ff1d529f6ca5
https://hg.mozilla.org/mozilla-central/rev/cbbeb9a286aa