1863256 - ./mach try perf --gecko-profile-interval doesn't accept floating number

Status: RESOLVED FIXED

(Testing :: Performance, defect, P3)

Description

[Makoto Kato [:m_kato]]

From ./mach try perf --help,

  --gecko-profile-interval GECKO_PROFILE_INTERVAL
                        How frequently to take samples (ms)

When I want to set this to 0.1 ms, this causes the following error.

[task 2023-11-06T05:43:52.085Z] executing ['/usr/bin/python3', '-u', 'mozharness/scripts/raptor_script.py', '--cfg', 'mozharness/configs/raptor/linux_config.py', '--chimera', '--conditioned-profile=settled', '--extra-profiler-run', '--browsertime-video', '--browsertime-visualmetrics', '--app=firefox', '--test=wikipedia', '--project=try', '--browsertime-browsertimejs', '$MOZ_FETCHES_DIR/browsertime/node_modules/browsertime/bin/browsertime.js', '--browsertime-node', '$MOZ_FETCHES_DIR/node/bin/node', '--browsertime-geckodriver', '$MOZ_FETCHES_DIR/geckodriver', '--browsertime-chromedriver', '$MOZ_FETCHES_DIR/{}chromedriver', '--browsertime-ffmpeg', '$MOZ_FETCHES_DIR/ffmpeg-4.4.1-i686-static/ffmpeg', '--gecko-profile', '--gecko-profile-interval=0.1', '--download-symbols', 'ondemand']
[task 2023-11-06T05:43:52.414Z] Usage: raptor_script.py [options]
[task 2023-11-06T05:43:52.414Z] 
[task 2023-11-06T05:43:52.414Z] raptor_script.py: error: option --gecko-profile-interval: invalid integer value: '0.1'

Is there no way to accept floating number for it?

Comment 1

[Kash Shampur [:kshampur] ⌚EST]

generally speaking, I don't think CI tasks could handle such a small interval like 0.1 as it would slow FF a lot

Comment 2

[Andrej (:aglavic)]

Hey Nazim, wanted to get your thoughts to see if you think that 0.1ms is something that we can realistically do in CI

Comment 3

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Sorry for the delay. Yes, I agree with Kash that a very small interval could slow down the execution of Firefox a lot, and that would skew the profile recording, making it a lot less useful to analyze.
But maybe CI machines are more powerful than I realize. Best way to test this is to push to try with a hard coded 0.1 interval (should be a straightforward 1-line patch) so we can see if the profiles are good enough or useful.

On the other hand, this comment applies to mach try perf but we should definitely support floating point numbers in mach raptor or mach talos (if we don't support it already). I'm looking at the --gecko-profile-interval argument in the source code but I'm getting mixed results. In some places it's stored as int and in some other places it's stored as float, so it would be good to consistently use float everywhere.

Comment 4

[Greg Mierzwinski [:sparky]]

Attachment: Bug 1863256 - Support float values for gecko-profile interval in raptor/talos. r?#perftest,canaltinova

This patch fixes an issue where we don't accept float values for gecko-profile-interval. It's possible to use float values here so we should support them like in other components.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83b9c7e20aec
Support float values for gecko-profile interval in raptor/talos. r=canaltinova,perftest-reviewers,kshampur DONTBUILD

Comment 6

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/83b9c7e20aec