1863260 - Thunderbird daily icons are not square dimensions

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[bbhtt]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:121.0) Gecko/20100101 Firefox/121.0

Steps to reproduce:

The daily icons here are not of square dimensions

https://hg.mozilla.org/comm-central/raw-file/tip/mail/branding/nightly/default64.png is 64x64

https://hg.mozilla.org/comm-central/raw-file/tip/mail/branding/nightly/default128.png is 129x128

https://hg.mozilla.org/comm-central/raw-file/tip/mail/branding/nightly/default256.png is 257x256

This makes appstream-compose fail when creating a flatpak package of thunderbird nightly with flatpak-builder.

These should be exactly 64x64, 128x128 and 256x256.

Comment 1

[bbhtt]

To reproduce, clone and checkout the test branch https://gitlab.com/projects261/thunderbird-nightly-flatpak/#build-locally then run flatpak-builder build --install-deps-from=flathub --force-clean --user --install org.mozilla.ThunderbirdNightly.yaml

It'll end with an error:

Exporting org.mozilla.ThunderbirdNightly to repo
error: /home/wirt/Git/gitlab/thunderbird-nightly-flatpak/build/export/share/icons/hicolor/64x64/apps/org.mozilla.ThunderbirdNightly.png is not a valid icon: Expected a square icon but got: 65x64

Export failed: Child process exited with code 1

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1863260 - Fix nightly branded icon sizes. r=#thunderbird-front-end-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7cc7629ca5ed
Fix nightly branded icon sizes. r=vineet