Closed Bug 1863339 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 42974 - Properly adjust StyleScope information when moving rules to diff rulesets.

Categories

(Core :: DOM: CSS Object Model, task, P4)

Product:
Core
Component:
DOM: CSS Object Model
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
121 Branch
Tracking Flags:
Tracking Status
firefox121 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 42974 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42974
Details from upstream follow.

Steinar H. Gunderson <sesse@chromium.org> wrote:

Properly adjust StyleScope information when moving rules to diff rulesets.

When copying RuleData from a normal ruleset to a diff ruleset,
we would not adjust their position; this would give an entirely
wrong position, which would then crash as we tried finding the
appropriate StyleScope to test against.

Properly adjust the position through a helper (expanding on
the one we used for Bloom filter hashes), and add the StyleScope
to the proper intervals.

Fixed: 1499277

Change-Id: I6d99809ac137d644cec8dc2d4f3ccf863c32ef0e

Reviewed-on: https://chromium-review.googlesource.com/5001880
WPT-Export-Revision: 47ecf4a04931a19589c0ce079598c0a32156016e

Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3f39b0edfc4d [wpt PR 42974] - Properly adjust StyleScope information when moving rules to diff rulesets., a=testonly
Test result changes from PR not available.
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/59da94ecb7e6 [wpt PR 42974] - Properly adjust StyleScope information when moving rules to diff rulesets., a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/59da94ecb7e6

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox121: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch
You need to log in before you can comment on or make changes to this bug.