1863426 - Tooltip in sidebar sticks when window gets minimized on macOS

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Andreas Wagner [:TheOne] [use NI]]

STR:

1. Install a sidebar extension like TreeStyleTab.
2. In the sidebar, hover over an item with a tooltip to make it appear. In TST, you can hover over the X on a tab to show "Close Tab".
3. Minimize the window using the keyboard shortcut. (Tested with CMD+M on MacOS)

Expected results:
The tooltip disappears as the window is minimized.

Actual results:
The window is minimized but the tooltip is still visible

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Hi Emilio,
this seems to be similar to Bug 148624 but hit tooltips being show for a moz-extension page opened in the sidebar panel, it seeems to be still reproducible on builds including the changes from Bug 148624 (at least on macos where I was also able to reproduce using the STR from comment 0, while I was unable to reproduce it on Linux builds while using gnome)

Do you have any idea or pointers for things we may want to look more closely into to determine what is still missing to fix this other similar issue?

Comment 2

[fanzhuyifan+github]

In Bug 148624 the issue was that the timer for showing the tooltip still fired and showed the tooltip even when the window went out of focus in the mean time, resulting in the tooltip incorrectly shown. This is different in that here the tooltip is correctly shown, but not correctly cancelled during window minimization.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1863426 - Roll up tooltips too in nsCocoaWindow's RollupPopups. r=#mac-reviewers

This matches what we do on other platforms too.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82618a3f937c
Roll up tooltips too in nsCocoaWindow's RollupPopups. r=mac-reviewers,spohl

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/82618a3f937c

Comment 6

[Simona Badau, Desktop QA]

Reproduced using Firefox 120 on macOS 11.7.
Verified as fixed using Firefox 121.0b2 (Build ID: 20231122091904) and the latest Nightly 122.0a1 (Build ID: 20231122215037) on macOS 11.7.