18635 - nsBasePrincipal.cpp attempts illegal cast

Status: VERIFIED DUPLICATE of bug 18640

(Core :: Security: CAPS, defect, P3)

Description

[tor]

The SUNWspro 4.2 compilers don't like casting directly from a void* to a short:

"/cs/src/mozilla/mozilla/caps/src/nsBasePrincipal.cpp", line 64: Error: Cannot
cast from void* to short.

Casting through an intermediate long makes the compiler happy:

Index: nsBasePrincipal.cpp
===================================================================
RCS file: /cvsroot/mozilla/caps/src/nsBasePrincipal.cpp,v
retrieving revision 1.1
diff -u -r1.1 nsBasePrincipal.cpp
--- nsBasePrincipal.cpp 1999/11/11 22:10:34     1.1
+++ nsBasePrincipal.cpp 1999/11/12 01:25:53
@@ -61,7 +61,7 @@
         return NS_OK;
     }
     nsStringKey key(capability);
-    *result = (PRInt16) mCapabilities->Get(&key);
+    *result = (PRInt16)(long)mCapabilities->Get(&key);
     if (!*result)
         *result = nsIPrincipal::ENABLE_UNKNOWN;
     return NS_OK;

Comment 1

[Norris Boyd]

What about casting through an int instead? Casting through a long seems odd for
machines where long is 64 bits but void * is 32.

Comment 2

[tor]

It's happy with that as well.

Comment 3

[Norris Boyd]

Checked in fix.

*** This bug has been marked as a duplicate of 18640 ***

Comment 4

[Joseph Elwell]

[bugday] verified dupe. different compilers but same bug.

Comment 5

[leger]

Moving all CAPS bugs to Security: CAPS component.  CAPS component will be 
deleted.