1863692 - Window location and size are not remembered when using restore session

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect, P1)

Description

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Attachment: session restore windows.webm

Found in

• Firefox 120.0b7

Affected versions

• Firefox 120.0b7
• Firefox 121.0a1

Tested platforms

• Affected platforms: Windows 11, macOS 13.6.1, Ubuntu 22.04
• Unaffected platforms:

Steps to reproduce

1. Launch Firefox
2. Access a couple websites in new windows
3. Modify the height/width of the windows and then exit Firefox via Menu
4. Reopen Firefox with the same profile
5. Click the Restore Previous Session option from the Hamburger menu

Expected result

• The previous window size and location on screen are preserved as before

Actual result

• The window location and size are not remembered when using restore session

Regression range

• Will see for a regression

Additional notes

• The issue can be seen in the attachment

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:csasca, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Alice0775 White]

I can reproduce the issue on Nightly120.0a1 Windows10

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=df74c724a47d95ff0e380c5ba587c03a25ddd93d&tochange=8737a1c1bc55e77b43e7c6daab1f7882a0b38ce7

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:sclements, since you are the author of the regressor, bug 1820660, could you take a look?

For more information, please visit BugBot documentation.

Comment 4

[Sarah Clements [:sclements]]

Thanks for catching that. I'll try to get a fix in for 121.

Comment 5

[Sarah Clements [:sclements]]

Thanks for filing the bug. I was able to reproduce this locally, and it looks like what's happening here is that whatever the first window's size is when the browser is closed, that is used to determine the size of all restored windows, not just the first one. I think its due to these window attributes we're transferring over when handling pinned tabs (and was changed in bug 1820660 to handle closedTabs as well) when a session restore is deferred on startup per here.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1820660

Comment 8

[Sarah Clements [:sclements]]

Attachment: Bug 1863692 - Only transfer window attributes for pinned tabs with deferred sessions r=#sessionstore-reviewers

• add new marionette test

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1a0d895f3a9
Only transfer window attributes for pinned tabs with deferred sessions r=sessionstore-reviewers,dao

Comment 10

[Noemi Erli[:noemi_erli]]

Backed out changeset e1a0d895f3a9 (Bug 1863692) for causing failures in test_restore_manually.py

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=N2YFY-8QQwaw2_vRLG7fIg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=e1a0d895f3a9eadc830c99e4d583c235c187163e

Log: https://treeherder.mozilla.org/logviewer?job_id=438726936&repo=autoland&lineNumber=15845

Backout: https://hg.mozilla.org/integration/autoland/rev/85e64ef6d1538ecd03a0c9ab416c70e37411a7aa

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa657711db7a
Only transfer window attributes for pinned tabs with deferred sessions r=sessionstore-reviewers,dao

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/aa657711db7a

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:sclements, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.

Comment 14

[Catalin Sasca, Desktop Test Engineering [:csasca]]

The issue is fixed on Firefox 122.0a1 (2023-12-07). Tests were performed on macOS 13.6.1, Ubuntu 22.04 and Windows 11.