1863730 - [Experiment] Both Sponsored and Non-Sponsored results can be triggered at the same time

Status: VERIFIED FIXED

(Firefox for Android :: Search, defect)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

[Affected versions]

• Firefox Beta 120.0b7 (Build #2015984306)
• Firefox Nightly 121.0a1 (Build ID: 2015984039)

[Affected platforms]

• One Plus 8 Pro, Android 13

[Prerequisites]

• Have the latest Nightly 121.0a1 or Firefox Beta 120 build installed.

[Steps to reproduce]

1. Open the Firefox build.
2. In the address bar type "mich" keyword.
3. Observe the results from Firefox Suggest.

[Expected results]

• Only one result from Rust is displayed for the typed keyword.

[Actual results]

• Two results from Rust are triggered, one for "Michael Kors" sponsored result and one for "Michael Gambon" non-sponsored result.

[Notes]

• The following keywords also trigger both sponsored and non-sponsored results:
• "pos" - triggers "Poshmark" sponsored and "Post Malone" Wikipedia
• "post" - triggers "Officedepot" sponsored and "Post Malone" Wikipedia
• The issue is not reproducible with the "carol" keyword like in the old issue Bug 1861414.
• Not sure if there are any other keywords, but I will add a comment if we find one.

Comment 1

[Nan Jiang [:nanj]]

Turns out there is a bug in our keyword deduping code, it's now fixed via this PR.

:cmuntean, thanks, nice find!

Comment 2

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 121.0a1 build (Build ID: 2015984999) and the latest Beta 121.0b8 (Build ID: 2015984722) on OnePlus 8 Pro with Android 13.

• Only one result from Rust is displayed for the typed keyword.