1863836 - [wpt-sync] Sync PR 43036 - Correctly handle a zero value for X25519 deriveBits' length parameter

Status: RESOLVED DUPLICATE of bug 1922522

(Core :: DOM: Web Crypto, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 43036 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43036
Details from upstream follow.

Javier Fernández García-Boente <[e-mail]> wrote:

Correctly handle a zero value for X25519 deriveBits' length parameter

The Secure Curves spec draft states that we should trunk the derived
bits based on any non-null value passed in the length parameter. Our
currently implementation has been considering zero like null, so we
are returning the entire derived bits array.

The bug 1433707 mentions on ongoing discussion related to the lack of
interoperability on the handling of the deriveBits' length parameter
in several algorithms, being the X25519 one of them. The proposed
change in the spec could be backward-incompatible, so we need time to
evaluate the impact on Chrome's implementation.

While the mentioned spec change discussion continues, this CL changes
the implementation of the X25519 algorithm to match the current spec.

Bug: 1433707
Change-Id: Ifbf5829db04bbc7c9ff916d27b586feae345b536
Reviewed-on: https://chromium-review.googlesource.com/5013612
WPT-Export-Revision: 5be8ece3024a5f09c0301dc64784d404d81f3d49

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=29cf6e42f28d60216a863546c298ac4eded083e2

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 30 tests and 1001 subtests

## Status Summary

### Firefox
`OK`  : 30
`PASS`: 22796
`FAIL`: 2286

### Chrome
`OK`  : 30
`PASS`: 23698
`FAIL`: 1384

### Safari
`OK`  : 30
`PASS`: 25016
`FAIL`: 66

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=29cf6e42f28d60216a863546c298ac4eded083e2)
[GitHub PR Head](https://wpt.fyi/results/?sha=ed73d7763447b16ff3cfffd82559229085b9d07b&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=ed73d7763447b16ff3cfffd82559229085b9d07b&label=pr_base)

## Details

(See attachment for full changes)

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 30 tests and 1001 subtests

## Status Summary

### Firefox
`OK`  : 30
`PASS`: 22796
`FAIL`: 2286

### Chrome
`OK`  : 30
`PASS`: 23698
`FAIL`: 1384

### Safari
`OK`  : 30
`PASS`: 25016
`FAIL`: 66

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=29cf6e42f28d60216a863546c298ac4eded083e2)
[GitHub PR Head](https://wpt.fyi/results/?sha=ed73d7763447b16ff3cfffd82559229085b9d07b&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=ed73d7763447b16ff3cfffd82559229085b9d07b&label=pr_base)

## Details

(See attachment for full changes)