Closed Bug 1863859 Opened 2 years ago Closed 1 year ago

[wpt-sync] Sync PR 43039 - [text-autospace] Sync width to `CharacterPositionData`

Categories

(Core :: Layout: Text and Fonts, task, P4)

Product:
Core
Component:
Layout: Text and Fonts
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
122 Branch
Tracking Flags:
Tracking Status
firefox122 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 43039 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43039
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

[text-autospace] Sync width to CharacterPositionData

When applying auto-spacing, this patch synchronizes
ShapeResult::width_ to CharacterPositionData::width_ if
the ShapeResult has CharacterPositionData.

They need to be in sync for CachedOffsetForPosition and
CachedPositionForOffset to work correctly, which are used
by ShapingLineBreaker.

While fixing this, tests discovered a bug where
ApplyTextAutoSpacingCore doesn't add the spacing to width_
for the RTL code path. Instead of fixing it, this patch
changes RecalcCharacterPositions to update both width_s.

ApplyTextAutoSpacing always calls RecalcCharacterPositions.
The code that adjusts width_ in ApplyTextAutoSpacingCore
is thus removed.

Bug: 1500655, 1463890
Change-Id: I4db7b7139fc09688b2af015f9d4bb622103025d5

Reviewed-on: https://chromium-review.googlesource.com/5014404
WPT-Export-Revision: 767c2caf94146be142ac3e468b62be9604ec0035

Component: web-platform-tests → Layout: Text and Fonts
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/23ca2fa53bdf [wpt PR 43039] - [text-autospace] Sync width to `CharacterPositionData`, a=testonly https://hg.mozilla.org/integration/autoland/rev/2064c54e2017 [wpt PR 43039] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/754350e249ec [wpt PR 43039] - [text-autospace] Sync width to `CharacterPositionData`, a=testonly https://hg.mozilla.org/integration/autoland/rev/ff10ce7af58d [wpt PR 43039] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/754350e249ec
https://hg.mozilla.org/mozilla-central/rev/ff10ce7af58d

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox122: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
You need to log in before you can comment on or make changes to this bug.