1863876 - firefox nightly fails to link in: function mozilla::widget::g_bus_get_callback(_GObject*, _GAsyncResult*, void*)': with: hidden symbol `_ZN7mozilla6widget17IsCancelledGErrorEP7_GError' isn't defined

Status: RESOLVED FIXED

(Firefox :: Untriaged, defect)

Description

[tt_1]

Attachment: build-6be424d7.log.xz

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

I downloaded latest github sources and compiled them, passing --disable-dbus

Actual results:

the build compiles but fails to link with missing references to dbus:

46:15.49 /usr/libexec/gcc/armv7a-unknown-linux-gnueabihf/ld.bfd: /var/tmp/portage/portage/www-client/firefox-121.0/work/firefox_build/toolkit/library/build/../../../widget/gtk/Unified_cpp_widget_gtk0.o: in function mozilla::widget::g_bus_get_callback(_GObject*, _GAsyncResult*, void*)': 46:15.49 Unified_cpp_widget_gtk0.cpp:(.text._ZN7mozilla6widget18g_bus_get_callbackEP8_GObjectP13_GAsyncResultPv+0x6e): undefined reference tomozilla::widget::IsCancelledGError(_GError*)'
46:15.49 /usr/libexec/gcc/armv7a-unknown-linux-gnueabihf/ld.bfd: libxul.so: hidden symbol `_ZN7mozilla6widget17IsCancelledGErrorEP7_GError' isn't defined
46:15.50 /usr/libexec/gcc/armv7a-unknown-linux-gnueabihf/ld.bfd: final link failed: bad value
46:15.50 collect2: error: ld returned 1 exit status

Expected results:

I expect the compiled sources to link without errors.

this is a regression from https://bugzilla.mozilla.org/show_bug.cgi?id=1859865 , locally reverting the patch works around the issue.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:stransky, since you are the author of the regressor, bug 1859865, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1863876 [Linux] Move IsCancelledGError() from AsyncDBus.h to WidgetUtilsGtk.h r?emilio

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a3457fbe467
[Linux] Move IsCancelledGError() from AsyncDBus.h to WidgetUtilsGtk.h r=emilio

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1859865

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/2a3457fbe467