18640 - sun workshop compiler c++ 5.0 fails to compile caps

Status: VERIFIED FIXED

(Core :: Security: CAPS, defect, P3)

Description

[Akhil Arora]

gmake[2]: Entering directory `/opt/ws/mozilla/caps/src'
CC -library=iostream -o nsBasePrincipal.o -c   -DMOZILLA_CLIENT -DBROKEN_QSORT=1
-DNSCAP_DISABLE_DEBUG_PTR_TYPES=1 -DMOZ_DEFAULT_TOOLKIT=\"gtk\" -DSTDC_HEADERS=1
-DHAVE_ST_BLKSIZE=1 -DHAVE_INT16_T=1 -DHAVE_INT32_T=1 -DHAVE_INT64_T=1
-DHAVE_UINT=1 -DHAVE_UINT_T=1 -DHAVE_UINT16_T=1 -DHAVE_SYS_BYTEORDER_H=1
-DHAVE_MEMORY_H=1 -DHAVE_UNISTD_H=1 -DHAVE_SYS_FILIO_H=1 -DHAVE_SYS_IPC_H=1
-DHAVE_SYS_SHM_H=1 -DHAVE_X11_EXTENSIONS_XSHM_H=1 -DHAVE_SYS_STATVFS_H=1
-DHAVE_SYS_STATFS_H=1 -DHAVE_SYS_VFS_H=1 -DHAVE_SYS_MOUNT_H=1 -DHAVE_LIBM=1
-DHAVE_LIBDL=1 -DHAVE_LIBRESOLV=1 -DHAVE_LIBSOCKET=1 -DHAVE_LIBNSL=1
-DHAVE_LIBELF=1 -DHAVE_LIBINTL=1 -DHAVE_LIBPOSIX4=1 -DHAVE_LIBW=1 -D_REENTRANT=1
-DHAVE_RANDOM=1 -DHAVE_QSORT=1 -DHAVE_STRERROR=1 -DHAVE_LCHOWN=1 -DHAVE_FCHMOD=1
-DHAVE_SNPRINTF=1 -DHAVE_LOCALTIME_R=1 -DHAVE_STATVFS=1 -DHAVE_MEMMOVE=1
-DHAVE_GETTIMEOFDAY=1 -DGETTIMEOFDAY_TWO_ARGS=1 -DHAVE_VALLOC=1
-DHAVE_IOS_BINARY=1 -DHAVE_OSTREAM=1 -DHAVE_CPP_EXPLICIT=1
-DHAVE_CPP_SPECIALIZATION=1 -DHAVE_CPP_USING=1 -DHAVE_CPP_NEW_CASTS=1
-DHAVE_I18N_LC_MESSAGES=1 -DMOZ_MAIL_NEWS=1 -DDEBUG=1 -DDEBUG_=1 -DTRACING=1
-DMOZ_USER_DIR=\".mozilla\" -DMOZ_DISABLE_DTD_DEBUG=1 -DMOZ_DLL_SUFFIX=\".so\"
-DXP_UNIX=1 -DUNIX_EMBED=1 -DX_PLUGINS=1 -DUNIX_LDAP=1 -DUNIX_ASYNC_DNS=1
-DJS_THREADSAFE=1 -DLAYERS=1  -mt -g  -KPIC  -DOSTYPE=\"SunOS5\" -DOJI
-I../../dist/include -I../../dist/include -I../../dist/include -I../../include
-I../../dist/public/jpeg -I../../dist/public/png -I../../dist/public/zlib
-I../../include -I./../include -I/usr/openwin/include  nsBasePrincipal.cpp
"nsBasePrincipal.cpp", line 64: Error: Cannot cast from void* to short.
1 Error(s) detected.
gmake[2]: *** [nsBasePrincipal.o] Error 1
gmake[2]: Leaving directory `/opt/ws/mozilla/caps/src'
gmake[1]: *** [libs] Error 2
gmake[1]: Leaving directory `/opt/ws/mozilla/caps'
gmake: *** [libs] Error 2

Comment 1

[Akhil Arora]

The following two-step cast compiles OK. Permission to check in?

RCS file: /cvsroot/mozilla/caps/src/nsBasePrincipal.cpp,v
retrieving revision 1.1
diff -r1.1 nsBasePrincipal.cpp
64c64
<     *result = (PRInt16) mCapabilities->Get(&key);
---
>     *result = (PRInt16) (PRInt32) mCapabilities->Get(&key);

Comment 2

[Norris Boyd]

Sure, check it in. r=norris. Mail me if you're going to, otherwise I'll take
care of it.

Thanks,
Norris

Comment 3

[Norris Boyd]

Checked in your fix. thanks.

Comment 4

[Norris Boyd]

*** Bug 18635 has been marked as a duplicate of this bug. ***

Comment 5

[Jim Dunn]

Thanks!  fixed HPUX also!

Comment 6

[leger]

Moving all CAPS bugs to Security: CAPS component.  CAPS component will be 
deleted.

Comment 7

[John Unruh]

Verified.