Closed
Bug 1864010
Opened 1 year ago
Closed 1 year ago
Modernize latency decision logic in AudioCallbackDriver
Categories
(Core :: Audio/Video: cubeb, defect)
Core
Audio/Video: cubeb
Tracking
()
RESOLVED
FIXED
122 Branch
Tracking | Status | |
---|---|---|
firefox122 | --- | fixed |
People
(Reporter: padenot, Assigned: padenot)
Details
Attachments
(1 file)
It's quite dated, we can do better
Assignee | ||
Comment 1•1 year ago
|
||
Android can now routinely have buffer sizes < 128 so let's remove the macOS
#ifdef, and explicitly cap to 128 because it's useless to go lower in the
current state of things. Add some logging messages to make everything clear.
Assignee | ||
Comment 2•1 year ago
|
||
This cubeb PR: https://github.com/mozilla/cubeb/pull/766 works in tandem with the changes here: AAudio will now call the MTG with 512-frames callbacks if using AudioProcessing
, or something very small otherwise (capped to 128).
Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55026b57b6b1
Modernize latency decision logic in AudioCallbackDriver. r=pehrsons
Comment 4•1 year ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox122:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•