1864339 - gDBView.hdrForFirstSelectedMessage doesn't work reliably in multi-folder views

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[Hartmut Welpmann [:welpy-cw]]

Steps to reproduce:

1. Enter a threaded multi-folder view.
2. Select all messages of an expanded thread making sure the last single selected message (current index as indicated by dotted border) hasn't been the root message.
3. Collapse the thread
4. Open the context menu of that row

Actual results:

Error console shows

Uncaught : Component returned failure code: 0x80550018 [nsIMsgDBView.hdrForFirstSelectedMessage]
    isCommandEnabled chrome://messenger/content/mailCommon.js:519
    fillMailContextMenu chrome://messenger/content/mailContext.js:330
    onPopupShowing chrome://messenger/content/mailContext.js:140
    handleEvent chrome://messenger/content/mailContext.js:127
    _onContextMenu chrome://messenger/content/about3Pane.js:5022
    handleEvent chrome://messenger/content/about3Pane.js:4647

Debugging reveals nsMsgSearchDBView::GetHdrForFirstSelectedMessage failing because mTreeSelection->GetCurrentIndex returns -1.

Expected result:

nsMsgSearchDBView::GetHdrForFirstSelectedMessage should return the first selected message indepently from the current index, as nsMsgDBView::GetHdrForFirstSelectedMessagedoes.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1864339 - Fix hdrForFirstSelectedMessage for multi-folder views. r=mkmelin

Comment 2

[Hartmut Welpmann [:welpy-cw]]

This is also responsible for the behavior reported in https://bugzilla.mozilla.org/show_bug.cgi?id=1856266#c15.

Comment 3

[Hartmut Welpmann [:welpy-cw]]

By the way, gDBView.hdrForFirstSelectedMessage was used very sparsely before Supernova,
see in particular get selectedMessage().

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/1daea7f19cfd
Fix hdrForFirstSelectedMessage for multi-folder views. r=mkmelin

Comment 5

[Wayne Mery (:wsmwk)]

Good for 115?

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9363172 [details]
Bug 1864339 - Fix hdrForFirstSelectedMessage for multi-folder views. r=mkmelin

[Triage Comment]
Approved for esr115

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 115.5.2:
https://hg.mozilla.org/releases/comm-esr115/rev/c6c96284e1c9