1864379 - `DOMForm.*` events fired for disconnected elements

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect, P3)

Comment 1

[Issam Mani [:issammani]]

Attachment: Bug 1864379 - P1. Don't dispatch LoginManager DOM events for disconnected input elements. r=dimi!,emilio!

Comment 2

[Issam Mani [:issammani]]

Attachment: Bug 1864379 - P2. Fix failing tests. r=dimi!

Depends on D194768

Comment 3

[Issam Mani [:issammani]]

Attachment: Bug 1864379 - P3. Remove obsolete PWMGR_PASSWORD_INPUT_IN_FORM telemetry probe. r=dimi!

Depends on D194769

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9af849c60d5f
P1. Don't dispatch LoginManager DOM events for disconnected input elements. r=dimi,emilio
https://hg.mozilla.org/integration/autoland/rev/62567e4688f9
P2. Fix failing tests. r=dimi
https://hg.mozilla.org/integration/autoland/rev/5f697f4aa6eb
P3. Remove obsolete PWMGR_PASSWORD_INPUT_IN_FORM telemetry probe. r=dimi

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/9af849c60d5f
https://hg.mozilla.org/mozilla-central/rev/62567e4688f9
https://hg.mozilla.org/mozilla-central/rev/5f697f4aa6eb

Comment 6

[Ryan VanderMeulen [:RyanVM]]

This grafts cleanly to Beta - how scary would this uplift be late in the cycle if we wanted to consider taking it in 121 for bug 1863300?

Comment 7

[Issam Mani [:issammani]]

The patch refactors things a bit and mimics the old behavior just omits sending events in some cases we don't need to. Since Bug 1863300 has high visibility, I think we can uplift this now.

Comment 8

[Issam Mani [:issammani]]

Attachment: Bug 1864379 - P1. Don't dispatch LoginManager DOM events for disconnected input elements. r=dimi!,emilio!

Original Revision: https://phabricator.services.mozilla.com/D194768

Comment 9

[Issam Mani [:issammani]]

Attachment: Bug 1864379 - P2. Fix failing tests. r=dimi!

Original Revision: https://phabricator.services.mozilla.com/D194769

Comment 10

[Issam Mani [:issammani]]

Attachment: Bug 1864379 - P3. Remove obsolete PWMGR_PASSWORD_INPUT_IN_FORM telemetry probe. r=dimi!

Original Revision: https://phabricator.services.mozilla.com/D194770

Comment 11

[Phabricator Automation]

Uplift Approval Request

• Steps to reproduce for manual QE testing: Try to login in https://store.playstation.com/de-de/pages/latest. It shouldn't freeze with the fix.
• Fix verified in Nightly: yes
• Is Android affected?: no
• String changes made/needed: No
• Code covered by automated testing: yes
• Explanation of risk level: The patch refactors things a bit and mimics the old behavior just omits sending events in some cases we don't need to. No additional risk is introduced.
• Needs manual QE test: no
• User impact if declined: Freezing behaviour when logging into some websites
• Risk associated with taking this patch: None

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9367095 [details]
Bug 1864379 - P1. Don't dispatch LoginManager DOM events for disconnected input elements. r=dimi!,emilio!

Approved for 121.0b8.

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/4ed06c87ffdb
https://hg.mozilla.org/releases/mozilla-beta/rev/358dbf2e8e48
https://hg.mozilla.org/releases/mozilla-beta/rev/65a56f162143

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1864379 - P1. Don't dispatch LoginManager DOM events for disconnected input elements.

Original Revision: https://phabricator.services.mozilla.com/D194768

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1864379 - P2. Fix failing tests.

Original Revision: https://phabricator.services.mozilla.com/D194769

Depends on D195780

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1864379 - P3. Remove obsolete PWMGR_PASSWORD_INPUT_IN_FORM telemetry probe.

Original Revision: https://phabricator.services.mozilla.com/D194770

Depends on D195781

Comment 17

[Phabricator Automation]

Uplift Approval Request

• Is Android affected?: no
• String changes made/needed: None
• Fix verified in Nightly: yes
• Steps to reproduce for manual QE testing: Try to login in https://store.playstation.com/de-de/pages/latest. It shouldn't freeze with the fix.
• Risk associated with taking this patch: None
• User impact if declined: Freezing behaviour when logging into some websites
• Needs manual QE test: no
• Explanation of risk level: The patch refactors things a bit and mimics the old behavior just omits sending events in some cases we don't need to. No additional risk is introduced.
• Code covered by automated testing: yes

Comment 18

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/8c2fb224d0e4
https://hg.mozilla.org/releases/mozilla-esr115/rev/8f268907679a
https://hg.mozilla.org/releases/mozilla-esr115/rev/e32000c11dca