[Linux/X11] Always paint to mContainer widget
Categories
(Core :: Widget: Gtk, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox122 | --- | fixed |
People
(Reporter: stransky, Assigned: stransky)
References
Details
Attachments
(6 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
On X11 we paint non-decorated windows to mShell and CSD windows to mContainer. We should unify our rendering and do paint to mContainer only as we do on Wayland.
That will provide only one rendering patch for both X11 and Wayland.
Assignee | ||
Comment 1•1 year ago
|
||
Comment 3•1 year ago
|
||
Backed out for causing mochitests failures in test_panel.xhtml.
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_panel.xhtml | noautohide panel with titlebar left
Assignee | ||
Comment 4•1 year ago
|
||
Thanks, will look at it.
Assignee | ||
Comment 5•1 year ago
|
||
We may fix the test for Wayland too as it produces this and more errors.
Assignee | ||
Comment 6•1 year ago
|
||
Looks like we're hitting Bug 1775017 here. But we should solve it somehow as it affects Wayland too where we always paint to mContainer.
Assignee | ||
Comment 7•1 year ago
|
||
Depends on D193401
Assignee | ||
Updated•1 year ago
|
Comment 9•1 year ago
|
||
Backed out 2 changesets (Bug 1864382) for causing valgrind bustages CLOSED TREE
Log: https://treeherder.mozilla.org/logviewer?job_id=436512227&repo=autoland&lineNumber=88188
Backout: https://hg.mozilla.org/integration/autoland/rev/8d800a6cd4bba679169de476b46798d5426f4585
Comment 10•1 year ago
|
||
Assignee | ||
Comment 11•1 year ago
|
||
Looks like we're not releasing GtkWindow implementation object:
_gdk_x11_display_create_window_impl()
{
...
impl = g_object_new (GDK_TYPE_WINDOW_IMPL_X11, NULL);
window->impl = GDK_WINDOW_IMPL (impl);
Assignee | ||
Comment 12•1 year ago
|
||
Looks like we can't destroy the impl_x11 object of child window. For toplevel windows it's deleted if the window is closed but child (embedded) doesn't destroy it. This affects other Gtk applications too like gedit or gnome-terminal.
Assignee | ||
Comment 13•1 year ago
|
||
Depends on D193497
Assignee | ||
Comment 14•1 year ago
|
||
Depends on D194621
Assignee | ||
Comment 15•1 year ago
|
||
Depends on D194622
Assignee | ||
Updated•1 year ago
|
Assignee | ||
Comment 16•1 year ago
|
||
Comment 17•1 year ago
|
||
Comment 18•1 year ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/64a25a56cdf1
https://hg.mozilla.org/mozilla-central/rev/8cfcb849655c
https://hg.mozilla.org/mozilla-central/rev/103edea66a48
https://hg.mozilla.org/mozilla-central/rev/b1c214141e4b
https://hg.mozilla.org/mozilla-central/rev/2c0e51ad0334
Assignee | ||
Comment 19•1 year ago
|
||
Comment 20•1 year ago
|
||
Comment 21•1 year ago
|
||
bugherder |
Updated•1 year ago
|
Description
•