1864482 - AppStream metainfo in Firefox Flatpak follows ancient AppStream specification

Status: VERIFIED FIXED

(Firefox :: Untriaged, enhancement)

Description

[Will Thompson]

Steps to reproduce:

appstreamcli validate --explain /var/lib/flatpak/exports/share/metainfo/org.mozilla.firefox.appdata.xml

Actual results:

E: ~:2: metainfo-ancient
The metainfo file uses an ancient version of the AppStream specification, which can not be
validated. Please migrate it to version 0.6 (or higher).

Validation failed: errors: 1

Expected results:

The file should validate without warnings.

Comment 1

[Will Thompson]

I prepared a couple of patches to update the file and fix some other warnings from the validator. I pushed them to GitHub as https://github.com/mozilla/gecko-dev/compare/master...wjt:gecko-dev:update-appdata and will attach them here.

I tried to follow the steps at https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html to get set up but at a certain stage in bootstrapping, the script failed because my distro (endless) is not on the list of hardcoded debian-like distros. I beg forgiveness.

Comment 2

[Will Thompson]

Attachment: 0001-Update-Flatpak-appdata-to-non-ancient-AppStream-spec.patch

Comment 3

[Will Thompson]

Attachment: 0002-Add-release-notes-URL-to-Flatpak-appdata.patch

Comment 4

[Will Thompson]

Attachment: Bug 1864482 - Update Flatpak appdata to non-ancient AppStream spec. r?jhorak

Previously, appstreamcli validate would warn:

E: ~:2: metainfo-ancient
   The metainfo file uses an ancient version of the AppStream specification, which can not be
   validated. Please migrate it to version 0.6 (or higher).

The old format is currently accepted by Flathub but will not be accepted
indefinitely.

Comment 5

[Will Thompson]

Attachment: Bug 1864482 - Add release notes URL to Flatpak appdata. r?jhorak

Ideally there would be a <description> element containing human-readable
release notes but this is not feasible with the current build process.
Instead, include the URL of the release notes on the web.

(I do not believe this URL is currently consumed by any frontends, but
perhaps one day it will be.)

Depends on D193447

Comment 6

[Will Thompson]

I got moz-phab working. I hope I followed https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html correctly!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a06843ec5608
Update Flatpak appdata to non-ancient AppStream spec. r=jcristau

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a06843ec5608

Comment 9

[Julien Cristau [:jcristau]]

$ appstreamcli validate ~/.local/share/flatpak/app/org.mozilla.firefox/x86_64/beta/active/export/share/metainfo/org.mozilla.firefox.appdata.xml 
I: org.mozilla.firefox:6: developer-name-tag-deprecated

✔ Validation was successful: infos: 1
$ appstreamcli validate ~/.local/share/flatpak/app/org.mozilla.firefox/x86_64/stable/active/export/share/metainfo/org.mozilla.firefox.appdata.xml
E: ~:2: metainfo-ancient

✘ Validation failed: errors: 1