Closed Bug 1864535 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 43124 - Pull common snap event wpt code together (part 2)

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
122 Branch
Tracking Flags:
Tracking Status
firefox122 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 43124 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43124
Details from upstream follow.

David Awogbemila <awogbemila@chromium.org> wrote:

Pull common snap event wpt code together (part 2)

Much of the test code written for snapchanged can be reused for
snapchanging. This is the second patch in a 2-patch attempt to put the
common code in one place: css/css-scroll-snap-2/resources/common.js so
that the functions can simply be called with either "snapchanged" or
"snapchanging" when we are adding tests for snapchanging.

Bug: 1494892, 1456339
Change-Id: I26cefefbb6bb9b8d878c0fff8e2eb694539cc8b6
Reviewed-on: https://chromium-review.googlesource.com/5025938
WPT-Export-Revision: 489977f72738cedef4fca06d512eadf272287d46

PR 43124 applied with additional changes from upstream: fe6c0e79ae54795068e316a3ca4aea9359baf17d, 6287285e2da1af4fa45c66a4d7f510bff60acc6c, 101005c254f529ba5b1b20bbd849d40dc5cafe5d, 1c79efa4efe301b0ec15bf95dc4d3654b5cd7494
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests and 1 subtests

Status Summary

Firefox

OK : 8
PASS: 2
FAIL: 21[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] 23[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub]

Chrome

OK : 8
FAIL: 23

Safari

OK : 8
FAIL: 23

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-scroll-snap-2/snapchanged/snapchanged-after-layout-change.tentative.html [wpt.fyi]
    • snapchanged fires after snap area is snapped to upon layout change.: FAIL (Chrome: FAIL, Safari: FAIL)
    • snapchanged fires after snap area is snapped to upon layout change without scroll.: FAIL (Chrome: FAIL, Safari: FAIL)
    • snapchanged fires when container stops snapping: FAIL (Chrome: FAIL, Safari: FAIL)
    • snapchanged fires when snap container no longer has snap areas: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-scroll-snap-2/snapchanged/snapchanged-ensures-dom-order.html [wpt.fyi]
    • snapchanged lists snapTargets in DOM order.: FAIL (Chrome: FAIL, Safari: FAIL)
    • DOM order change doesn't trigger snapchanged if snapped targets don't change.: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-scroll-snap-2/snapchanged/snapchanged-on-programmatic-root-scroll.tentative.html [wpt.fyi]
    • snapchanged event fires after snap target changes via scrollTo: FAIL (Chrome: FAIL, Safari: FAIL)
    • snapchanged is not fired if snap target doesn't change on programmatic scroll: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-scroll-snap-2/snapchanged/snapchanged-on-programmatic-scroll.tentative.html [wpt.fyi]
    • snapchanged event fires after snap target changes via scrollTo: FAIL (Chrome: FAIL, Safari: FAIL)
    • snapchanged is not fired if snap target doesn't change on programmatic scroll: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-scroll-snap-2/snapchanged/snapchanged-on-user-root-scroll.tentative.html [wpt.fyi]
    • snapchanged event fires after snap target changes on touch scroll: FAIL (Chrome: FAIL, Safari: FAIL)
    • snapchanged event fires after snap target changes on wheel scroll: FAIL (Chrome: FAIL, Safari: FAIL)
    • snapchanged event fires after snap target changes on scrollbar drag: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: FAIL, Safari: FAIL)
    • snapchanged event fires after snap target changes on keydown press: FAIL (Chrome: FAIL, Safari: FAIL)
    • snapchanged is not fired if snap target doesn't change on user scroll: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-scroll-snap-2/snapchanged/snapchanged-on-user-scroll.tentative.html [wpt.fyi]
    • snapchanged event fires after snap target changes on touch scroll: FAIL (Chrome: FAIL, Safari: FAIL)
    • snapchanged event fires after snap target changes on wheel scroll: FAIL (Chrome: FAIL, Safari: FAIL)
    • snapchanged event fires after snap target changes on scrollbar drag: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview] (Chrome: FAIL, Safari: FAIL)
    • snapchanged event fires after snap target changes on keydown press: FAIL (Chrome: FAIL, Safari: FAIL)
    • snapchanged is not fired if snap target doesn't change on user scroll: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-scroll-snap-2/snapchanged/snapchanged-same-targets-after-layout-changed.html [wpt.fyi]
    • snapchanged doesn't fire after layout change if snapped to the same elements: FAIL (Chrome: FAIL, Safari: FAIL)
    • snapchanged doesn't fire after snap to the same targets after scroll. elements: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-scroll-snap-2/snapchanged/snapchanged-with-proximity-strictness.tentative.html [wpt.fyi]
    • Snapchanged fires when scrolling outside proximity range.: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e5c9b54cd058 [wpt PR 43124] - Pull common snap event wpt code together (part 2), a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3b8d650a7981 [wpt PR 43124] - Pull common snap event wpt code together (part 2), a=testonly

https://hg.mozilla.org/mozilla-central/rev/3b8d650a7981

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox122: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
You need to log in before you can comment on or make changes to this bug.