Closed Bug 1864558 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 43133 - Add user gesture checks to showPicker and fullscreen invoke actions

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
122 Branch
Tracking Flags:
Tracking Status
firefox122 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 43133 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/43133
Details from upstream follow.

Luke Warlow <luke@warlow.dev> wrote:

Add user gesture checks to showPicker and fullscreen invoke actions

These were originally absent due to a faulty assumption.
If invokers only worked with trusted input then these checks
wouldn't be needed, but invokers also work with synthetic events.

As currently specced showPicker needs a user gesture check regardless.
Fullscreen actions aren't currently specced but adding gesture checks
matches the JS API equivalents, and removes a bypass for mitigations.

Bug: 1490919
Change-Id: I0b27e7110fc09bd4c8746d8bdddf200360640be9
Reviewed-on: https://chromium-review.googlesource.com/5019385
WPT-Export-Revision: 5868096d6d2cdd8fddfdb3b05d17d455987cc367

PR 43133 applied with additional changes from upstream: 9b17436bfc5af59287a1c430de32b99a8a866f5c
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 12 subtests

Status Summary

Firefox

OK : 1
PASS: 7
FAIL: 5

Chrome

OK : 1
PASS: 12

Safari

OK : 1
PASS: 7
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/semantics/invokers/invoketarget-fullscreen-behavior.tentative.html [wpt.fyi]
    • invoking div with toggleFullscreen action makes div fullscreen: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking fullscreen div with toggleFullscreen action exits fullscreen: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking fullscreen div with toggleFullscreen (case-insensitive) action exits fullscreen: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking div with requestFullscreen action makes div fullscreen: FAIL (Chrome: PASS, Safari: FAIL)
    • invoking fullscreen div with exitFullscreen action exits fullscreen: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/279ddb63b796 [wpt PR 43133] - Add user gesture checks to showPicker and fullscreen invoke actions, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8203641ccd3f [wpt PR 43133] - Add user gesture checks to showPicker and fullscreen invoke actions, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8203641ccd3f

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox122: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
You need to log in before you can comment on or make changes to this bug.