1864582 - Don't save folder sort order value if no siblings have an order value

Status: RESOLVED DUPLICATE of bug 1846550

(Thunderbird :: Folder and Message Lists, defect)

Description

[Geoff Lankow (:darktrojan)]

If a new folder is added, and none of its siblings have ever been sorted, we should not set a sort order value on the new folder. Currently we do set a value, and this causes any new folders to be added to the start of the list instead of in the natural order.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1864582 - Don't set a folder sort order value when no siblings are sorted. r=#thunderbird-reviewers

Comment 2

[itagagaki]

I think I coded it that way. But it isn't? I will look into it.

Comment 3

[itagagaki]

Ah, I see. It still invoke the DB, even if we do set same value. My bad.

Comment 4

[Geoff Lankow (:darktrojan)]

I meant to say in the first comment that this causes the test failure we've been seeing in mail/base/test/browser/browser_folderTreeQuirks.js. It deletes (in order) folderX, folderY and folderZ. The folders then appear in the list (as subfolders of the trash folder) in the order folderZ, folderY and folderX.

Comment 6

[Magnus Melin [:mkmelin]]

Duping this into 1846550 as the original fix got backed out and this fix should be baked into the main one before it relands.