Closed Bug 1864604 Opened 11 months ago Closed 11 months ago

[wpt-sync] Sync PR 42835 - [keepalive-migration] Check mixed content when RFH is alive

Categories

(Core :: DOM: Networking, task, P4)

Product:
Core
Component:
DOM: Networking
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
122 Branch
Tracking Flags:
Tracking Status
firefox122 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 42835 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/42835
Details from upstream follow.

Ming-Ying Chung <mych@chromium.org> wrote:

[keepalive-migration] Check mixed content when RFH is alive

  • The existing implementation in Blink 1 does not block mixed
    content 2 fetch keepalive requests, tracked by
    https://crbug.com/1500989.
  • The migration proxied fetch keepalive request loading via browser.
  • After recent change 3, the proxied requests are handled in browser
    first, and the redirects/responses will be forwarded back to
    renderer later (if still alive). It is better for browser to perform
    the same checks as what are done in renderer, including mixed content
    checking.

Bug: 1356128
Change-Id: Ifc7efe8d2b015bcf4d9d3f8229bb0997852847c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4988570
Reviewed-by: Tsuyoshi Horo \<horo@chromium.org>
Commit-Queue: Ming-Ying Chung \<mych@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1224130}

PR 42835 applied with additional changes from upstream: 2042ee3edaab162e9bc632f4361a9f5b7e783e19
Component: web-platform-tests → DOM: Networking
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

ERROR: 4

Chrome

ERROR: 4

Safari

ERROR: 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/75a7881f9980 [wpt PR 42835] - [keepalive-migration] Check mixed content when RFH is alive, a=testonly https://hg.mozilla.org/integration/autoland/rev/a0b1e07d5053 [wpt PR 42835] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8305bd4ae308 [wpt PR 42835] - [keepalive-migration] Check mixed content when RFH is alive, a=testonly https://hg.mozilla.org/integration/autoland/rev/1f1b4b2508cf [wpt PR 42835] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8305bd4ae308
https://hg.mozilla.org/mozilla-central/rev/1f1b4b2508cf

Status: NEW → RESOLVED
Closed: 11 months ago
status-firefox122: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
You need to log in before you can comment on or make changes to this bug.