1864675 - Add pretty printers for SyncedContext fields

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Andreas Farre [:farre]]

The synced context uses the empty base class optimization to pack synced fields. Unfortunately it makes synced fields pretty hard to read and because of that it would be good to have a gdb pretty printer filtering out the empty base classes.

Comment 1

[Simon Farre [:sfarre]]

Attachment: Bug 1864675 - Add pretty printers for SyncedContext fields r=farre!,nalexander!

Makes debugging of synced context fields more palatable.

Comment 2

[Andreas Farre [:farre]]

Can you attach a screenshot of how this looks in practice?

Comment 3

[Simon Farre [:sfarre]]

Attachment: Example on how it looks in VSCode

Pretty printing example

Comment 4

[Andreas Farre [:farre]]

This looks really nice. Thank you for helping out and improving synced fields debugability.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e331d786fff5
Add pretty printers for SyncedContext fields r=farre,nalexander

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/e331d786fff5