1864726 - Cleanup custom images in notifications

Status: NEW

(Toolkit :: PopupNotifications and Notification Bars, task)

Description

[Hanna Jones [:hjones]]

Previously it was possible to pass a custom image when creating a notification via calling notificationbox.appendNotification. There are still a good number of places in the app where we're passing images to appendNotification calls [1]. However this no longer works as expected - the code was removed during the Proton refresh as part of Bug 1711519.

I'm assuming that was a conscious decision to stop providing the option to customize the notification icon, in which case we should cleanup all the places where we're passing image as a notificaitonbox option.

[1] A (probably) complete list of places where we're passing custom icons that don't get shown:

1. https://searchfox.org/mozilla-central/rev/90dce6b0223b4dc17bb10f1125b44f70951585f9/browser/actors/DecoderDoctorParent.sys.mjs#260
2. https://searchfox.org/mozilla-central/rev/90dce6b0223b4dc17bb10f1125b44f70951585f9/browser/actors/EncryptedMediaParent.sys.mjs#169
3. https://searchfox.org/mozilla-central/rev/90dce6b0223b4dc17bb10f1125b44f70951585f9/browser/actors/PluginParent.sys.mjs#189
4. https://searchfox.org/mozilla-central/rev/90dce6b0223b4dc17bb10f1125b44f70951585f9/browser/actors/SpeechDispatcherParent.sys.mjs#83
5. https://searchfox.org/mozilla-central/rev/90dce6b0223b4dc17bb10f1125b44f70951585f9/browser/base/content/browser.js#9024
6. https://searchfox.org/mozilla-central/source/browser/base/content/tabbrowser.js#5886
7. https://searchfox.org/mozilla-central/source/browser/components/BrowserGlue.sys.mjs#1559
8. https://searchfox.org/mozilla-central/rev/90dce6b0223b4dc17bb10f1125b44f70951585f9/browser/components/aboutlogins/AboutLoginsParent.sys.mjs#719
9. https://searchfox.org/mozilla-central/rev/90dce6b0223b4dc17bb10f1125b44f70951585f9/browser/components/newtab/lib/InfoBar.jsm#45
10. https://searchfox.org/mozilla-central/rev/90dce6b0223b4dc17bb10f1125b44f70951585f9/browser/components/protocolhandler/WebProtocolHandlerRegistrar.sys.mjs#166
11. https://searchfox.org/mozilla-central/rev/90dce6b0223b4dc17bb10f1125b44f70951585f9/browser/modules/ContentCrashHandlers.sys.mjs#424
12. https://searchfox.org/mozilla-central/rev/90dce6b0223b4dc17bb10f1125b44f70951585f9/browser/modules/ContentCrashHandlers.sys.mjs#1097
13. https://searchfox.org/mozilla-central/rev/90dce6b0223b4dc17bb10f1125b44f70951585f9/browser/modules/ProcessHangMonitor.sys.mjs#571
14. https://searchfox.org/mozilla-central/rev/90dce6b0223b4dc17bb10f1125b44f70951585f9/toolkit/components/normandy/lib/Heartbeat.sys.mjs#156

Comment 1

[Hanna Jones [:hjones]]

there's also some usage of image in the notificationbox tests that we should clean up as part of this work - for example: https://searchfox.org/mozilla-central/rev/381c3f18a1896792e23a9503c1904aedac19aa06/toolkit/content/tests/chrome/test_notificationbox.xhtml#168