1864819 - Grid highlighter is shown when dismissing color picker, even if checkbox is unchecked

Status: VERIFIED FIXED

(DevTools :: Inspector: Layout, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Go to https://ffx-devtools-css-nesting.glitch.me/
2. Open the inspector, select the layout panel, expand the grid section if it's not
3. There should be a grid element, click on the color swatch
4. Once it's open, hit Esc to hide it

Expected results

Nothing

Actual results

when the popup is closed, the highlighter gets displayed, with a semi transparent style

---

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1864819 - [devtools] Don't automatically show grid highlighter on color change. r=#devtools-reviewers.

We shouldn't show the highlighter if its associated checkbox isn't checked,
unless it's a parent grid with an highlighted subgrid.
A test case is added, which need highlighter-shown to be emitted
from showParentGridHighlighter so we can assert it's not fired.

Depends on D193632

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c7ba8f44f26
[devtools] Don't automatically show grid highlighter on color change. r=devtools-reviewers,ochameau.

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/3c7ba8f44f26

Comment 4

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-11-15 Nightly build on Windows 10.
Verified as fixed on Firefox 121.0b4 and Nightly 122.0a1 on Windows 10, Ubuntu 22, macOS 12.