Closed Bug 1865128 Opened 2 years ago Closed 2 years ago

macOS passkey modal disappears and blocks Firefox main thread if the user has a Touch ID fingerprint registered

Categories

(Core :: DOM: Web Authentication, defect, P2)

Desktop
macOS
defect

Tracking

()

VERIFIED FIXED
122 Branch
Tracking Status
firefox121 --- verified
firefox122 --- verified

People

(Reporter: tetsuharu, Assigned: keeler)

References

Details

Attachments

(3 files)

Environments

Steps to Reproduce

  1. Open https://github.com/login
  2. Fill my id & password and click "Sign in" button.
  3. Click "Use passkey or security keys" button.

Actual Results

  1. Display macOS's passkey window but it will be closed soon automatically.
  2. Cannot interact with Firefox window that contains the tab opening the above page.
    • It looks like Firefox freezes.
    • But I still interact with the window from menu (e.g. "File" -> "New Window").

Expected

  • Firefox window should works well.
  • Success to sign in with macOS' passkey window.

Note

  • I confirms this is reproducible on macOS Sonoma 14.1.1 on Apple Silicon.
Summary: Firefox's window cannot be interactive after displaying macOS' passkey window on macOS Ventura → Firefox's window cannot be interactive after displaying macOS' passkey window
Attached video Video showing the issue

I can confirm that this happened to me as well a few days ago, for some reason not all devices are affected since I tried on multiple MacBooks both MacOS 13.6 (22G120) and MacOS 14 (all intel). On the single device that was affected I created a new user and the dialogue was not closed anymore automatically.
I also tried to get some logs by setting macoswebauthnservice:5 in about:logging or setting it as environment variable but I got an empty file.

Attaching a video with the issue using https://webauthn.io/ website.

I've reproduced this and I found that it depends on whether the user has a Touch ID fingerprint registered. If there's a fingerprint, the dialog disappears. If not, it shows.

Assignee: nobody → dkeeler
Severity: -- → S3
Status: NEW → ASSIGNED
Priority: -- → P2
Summary: Firefox's window cannot be interactive after displaying macOS' passkey window → macOS passkey modal disappears and blocks Firefox main thread if the user has a Touch ID fingerprint registered

Having the * denominator causes a bug with passkeys

Echoing something in the phab revision for posterity:

To add an explanation for the record: we don't need this for the developer entitlements because they don't use the passkey entitlement (and the requisite application-identifier entitlement) because that requires signing with an official Developer ID cert which we do not do for try builds.

Pushed by hneiva@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3e089d41cd6b Use full bundle id in entitlements r=haik,releng-reviewers,taskgraph-reviewers,bhearsum
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch

The patch landed in nightly and beta is affected.
:keeler, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(dkeeler)

Just as a note, QA will require this to be uplifted in Firefox 121 beta build so we can complete the testing on this feature since we do have tests that also cover the Touch ID being activated.

Having the * denominator causes a bug with passkeys

Original Revision: https://phabricator.services.mozilla.com/D193977

Attachment #9365039 - Flags: approval-mozilla-beta?

Uplift Approval Request

  • Is Android affected?: no
  • Steps to reproduce for manual QE testing: Register a credential on webauthn.io with security.webauthn.enable_macos_passkeys set to true.
  • Risk associated with taking this patch: No foreseeable risk
  • String changes made/needed: None
  • User impact if declined: passkeys won't work until next beta release
  • Fix verified in Nightly: yes
  • Code covered by automated testing: no
  • Explanation of risk level: working on nightly
  • Needs manual QE test: yes
Flags: qe-verify+

Comment on attachment 9365039 [details]
Bug 1865128 - Use full bundle id in entitlements

Approved for 121.0b3

Attachment #9365039 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Verified as fixed on Mac 13/Mac 14 using FF builds 121.0b3 and 122.0a1.
Mark as verified.

Status: RESOLVED → VERIFIED
Flags: needinfo?(dkeeler)
See Also: → 1886247
See Also: → 1953048
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: