Closed Bug 186515 Opened 22 years ago Closed 22 years ago

no content in sidebar

Categories

(SeaMonkey :: Sidebar, defect)

Product:
SeaMonkey
Component:
Sidebar
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: yuanyi21, Assigned: yuanyi21)

Details

Attachments

(1 file)

1-line patch
571 bytes, patch
shliang
: review+
jag+mozilla
: superreview+
asa
: approval1.3b-
asa
: approval1.3+
Details | Diff | Splinter Review 
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3b) Gecko/20021223

Steps to reproduce:
1. collapse (not close) the sidebar;
2. restart mozilla;
3. drag (not click) the sidebar splitter to make sidebar panel visible.

Result:
there is no content in the sidebar, only gray background.
Attached patch 1-line patch — — Splinter Review 

    
  

        Attachment #109969 -
        Flags: review?(sgehani)

    
  

        Attachment #109969 -
        Flags: review?(sgehani) → review?(aaronl)

    
  

        Attachment #109969 -
        Flags: superreview?(Henry.Jia)

    
    

    
  
Why use 100(ms) to refresh?
Summary: no content in sidebar → no content in sidebar

    
    

    
  
see
http://lxr.mozilla.org/seamonkey/source/xpfe/components/sidebar/resources/sidebarOverlay.js#1462

that is same action as grippy click (instead of dragging)
Assignee: sgehani → kyle.yuan

    
    

    
  
Comment on attachment 109969 [details] [diff] [review]
1-line patch

Samir owns sidebar. Also, the app group wants all chrome changes to go through
jag.

        Attachment #109969 -
        Flags: superreview?(jaggernaut)

        Attachment #109969 -
        Flags: superreview?(Henry.Jia)

        Attachment #109969 -
        Flags: review?(sgehani)

        Attachment #109969 -
        Flags: review?(aaronl)

    
    

    
  
Comment on attachment 109969 [details] [diff] [review]
1-line patch

Shuehan will be working on sidebar in our group going forward so I'll let her
review this.

        Attachment #109969 -
        Flags: review?(sgehani) → review?(shliang)

    
    

    
  
Comment on attachment 109969 [details] [diff] [review]
1-line patch

sr=jag

        Attachment #109969 -
        Flags: superreview?(jaggernaut) → superreview+

    
    

    
  
Comment on attachment 109969 [details] [diff] [review]
1-line patch

r=shuehan

        Attachment #109969 -
        Flags: review?(shliang) → review+

    
    

    
  
Comment on attachment 109969 [details] [diff] [review]
1-line patch

This is a 1-line patch, and it just delays a same function call 100ms likes
what we did in the other functions.

        Attachment #109969 -
        Flags: approval1.3b?

    
    

    
  
Comment on attachment 109969 [details] [diff] [review]
1-line patch

I think we're finished with 1.3beta so this will have to wait until final.

        Attachment #109969 -
        Flags: approval1.3b? → approval1.3b-

    
    

    
  
Comment on attachment 109969 [details] [diff] [review]
1-line patch

risk described in comment 8.

        Attachment #109969 -
        Flags: approval1.3?

    
    

    
  
Comment on attachment 109969 [details] [diff] [review]
1-line patch

a=asa(on behalf of drivers) for checkin to 1.3 final.

        Attachment #109969 -
        Flags: approval1.3? → approval1.3+

    
    

    
  
fixed in trunk!
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED

    
    

    
  
verified mozilla build 2003040105
Status: RESOLVED → VERIFIED
QA Contact: sujay → gbush
Product: Browser → Seamonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: