1865150 - fxaclient's getSessionToken should not throw in case of a missing sessionToken

Status: NEW

(Application Services :: Fxa Client, defect, P3)

Description

[Mark Hammond [:markh] [:mhammond]]

From github: https://github.com/mozilla/application-services/issues/2202.

From the method's docs:

@throws FxaException Will send you an exception if there is no session token set.

However, since this method is simply reading some data from in-memory state, simply returning String? will suffice here, and will make dealing with this method much easier.

┆Issue is synchronized with this Jira Task
┆Epic: Moving fxa-client functionality out of android-components

Change performed by the Move to Bugzilla add-on.

Comment 1

[Ben Dean-Kawamura [:bdk]]

This seems reasonable to me, but it's fairly old and I'm not sure if we should change the API at this point. Maybe it would make more sense to add a new method that didn't throw. Also maybe it's not that big of an issue for the android-components code anymore. I think we should rethink this once the code has been migrated to app-services.