1865273 - Rich suggestions are always bottom

Status: VERIFIED FIXED

(Firefox :: Address Bar, enhancement, P2)

Description

[Dale Harvey (:daleharvey)]

Regardless of the order we receive suggestions in, when they are sorted any suggestions with images come out last. I believe this is a timing issue due to the inline data uri taking a longer time to process.

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Bug 1865273 - Don't group rich suggestions last in urlbar results. r=adw

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7e5b4cd4c20
Don't group rich suggestions last in urlbar results. r=adw

Comment 3

[Cristian Tuns]

Backed out for causing bc failures in browser_searchShowSuggestionsFirst.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/browser_searchShowSuggestionsFirst.js | Checkbox should become unchecked after disabling urlbar suggestions - false == true - {"filename":"chrome://mochitests/content/browser/browser/components/preferences/tests/browser_searchShowSuggestionsFirst.js","name":"superprefInteraction","sourceId":8894,"lineNumber":141,"columnNumber":12,"sourceLine":"","asyncCause":null,"asyncCaller":{"filena

Comment 4

[Cristian Tuns]

Sorry for this, it looks like it is not caused by this bug. Relanded

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2df2da5ead3a
Don't group rich suggestions last in urlbar results. r=adw

Comment 6

[Dale Harvey (:daleharvey)]

Cheers yeh I didnt think the above failure was related, there was an intermittent filed immediately on landing so I was investigating that but can continue to do so and see how this landing effects things

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2df2da5ead3a

Comment 8

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified during Nightly sign-off testrun for this feature that Rich Suggestions are now alongside other suggestions in Nightly 122.0a1 under Win 11 64-bit, Ubuntu 22.04 and macOS 13.