1865387 - Don't recreate session-store's history listener for browsing-context-did-set-embedder notification if browserId didn't change

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Peter Van der Beken [:peterv]]

This is causing issues when enabling SHIP on Android, because we end up resetting the listener and notifying multiple times about history changes. Both desktop and Android have the same code to install this listener, so we should fix both.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: Bug 1865387 - Don't recreate session-store's history listener for browsing-context-did-set-embedder notification if browserId didn't change.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:sfoster, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Sam Foster [:sfoster] (he/him)]

:peterv, can you provide a severity estimate? Sounds like maybe s3?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fd6571608c5
Don't recreate session-store's history listener for browsing-context-did-set-embedder notification if browserId didn't change. r=geckoview-reviewers,nika,sessionstore-reviewers,owlish,kaya,farre

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2fd6571608c5

Comment 6

[Andrej (:aglavic)]

(In reply to Pulsebot from comment #4)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fd6571608c5
Don't recreate session-store's history listener for
browsing-context-did-set-embedder notification if browserId didn't change.
r=geckoview-reviewers,nika,sessionstore-reviewers,owlish,kaya,farre

Perfherder has detected a talos performance change from push 2fd6571608c562d4703ad38ef440cb9c437d0046.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
3%	cross_origin_pageload	windows10-64-shippable-qr	e10s fission stylo webrender-sw	257.46 -> 250.26
3%	cross_origin_pageload	windows10-64-shippable-qr	e10s fission stylo webrender-sw	257.58 -> 250.41

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 161

For more information on performance sheriffing please see our FAQ.