1865558 - Some regressions in how elements appear in the print dialog

Status: VERIFIED FIXED

(Toolkit :: Printing, defect, P3)

Description

[Itiel]

Namely:

1. Some <select>s aren't the same height
2. Some <select>s don't have their text aligned to the center
3. Margins, Copies and Scale input spinner are too tall

These could be regressions from the tokens changes that landed somewhat lately, not sure, haven't tested for regression range yet.

Comment 1

[Itiel]

Attachment: Bug 1865558 - Make sure all <select>s are 32px high, plus other visual fixes r?mstriemer,#theme

Comment 2

[Timea Zsoldos [:tzsoldos], Desktop QA]

Regression range

• First bad: 2023-09-20
• Last good: 2023-09-19
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=36e95068e10391b8f3460c36e5651343feb808ab&tochange=cf2c8ac2f33c6120ce6219b5de00b29f886797ae
• Potential regressor: 1838939

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3b0030720a1
Make sure all <select>s are 32px high, plus other visual fixes r=desktop-theme-reviewers,emilio

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b3b0030720a1

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:itiel_yn8, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox125 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Issue is reproducible on a 2024-03-17 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 127.0a1 and Firefox 126.0 on Windows 10, Ubuntu 22, macOS 12.