Closed Bug 1865589 Opened 8 months ago Closed 4 months ago

Implement proper style invalidation for custom state pseudo class

Categories

(Core :: DOM: Core & HTML, defect)

Firefox 121
defect

Tracking

()

RESOLVED FIXED
126 Branch
Tracking Status
firefox126 --- fixed

People

(Reporter: mozilla, Assigned: mozilla)

References

Details

(Keywords: perf-alert)

Attachments

(1 file)

Currently adding a state to CustomStateSet will not invalidate the styles and as such it does not have immediate effect.

Style invalidation needs to be properly implemented to ensure updates to CustomStateSet have immediate effect.

Blocks: 1588763
Duplicate of this bug: 1865588
Severity: -- → S3
Attachment #9382069 - Attachment description: WIP: WIP! Bug 1865589 - Notify document of CustomState changes, so Restyle can invalidate. → WIP: Bug 1865589 - Notify document of CustomState changes, so Restyle can invalidate.
Assignee: nobody → mozilla
Attachment #9382069 - Attachment description: WIP: Bug 1865589 - Notify document of CustomState changes, so Restyle can invalidate. → WIP: Bug 1865589 - Notify PresShell of CustomState changes, so Restyle can invalidate.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9382069 - Attachment description: WIP: Bug 1865589 - Notify PresShell of CustomState changes, so Restyle can invalidate. → Bug 1865589 - Notify PresShell of CustomState changes, so Restyle can invalidate. r=emilio
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/15f8a83ad125
Notify PresShell of CustomState changes, so Restyle can invalidate. r=emilio,dshin
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/45292 for changes under testing/web-platform/tests
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
Upstream PR merged by moz-wptsync-bot

(In reply to Pulsebot from comment #3)

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/15f8a83ad125
Notify PresShell of CustomState changes, so Restyle can invalidate.
r=emilio,dshin

== Change summary for alert #42084 (as of Mon, 01 Apr 2024 18:03:10 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
4% ts_paint macosx1015-64-shippable-qr e10s fission stylo webrender-sw 822.38 -> 792.08
3% startup_about_home_paint macosx1015-64-shippable-qr e10s fission stylo webrender-sw 1,007.21 -> 979.00
2% startup_about_home_paint macosx1015-64-shippable-qr e10s fission stylo webrender-sw 1,012.42 -> 995.17

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=42084

Keywords: perf-alert
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: