1865592 - `./mach ide vscode` fails with `Exception: Process executed with non-0 exit code None`

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, defect)

Description

[Yannis Juglaret [:yannis]]

See bug 1814525 comment 15 and bug 1814525 comment 17. ./mach ide vscode fails with Exception: Process executed with non-0 exit code None on my Windows 11 laptop after the patch from bug 1845125. I put extra details and suggestions for code change in my comments from bug 1814525, but I have a more minimalist patch that is enough to fix the issue on my laptop.

Comment 1

[Yannis Juglaret [:yannis]]

Attachment: Bug 1865592 - Proceed to Process.wait if ProcessReader thread is successfully joined. r=#firefox-build-system-reviewers

In ProcessHandlerMixin.wait, if the ProcessReader thread is successfully
joined during the last second of timeout, we currently return None. This
can make us return None when the process has already exited. Instead, we
should check if joining was successful, and proceed to normal
Process.wait if it was.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab3b36e651d9
Proceed to Process.wait if ProcessReader thread is successfully joined. r=firefox-build-system-reviewers,sergesanspaille

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/ab3b36e651d9

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1845125