1865691 - Update PDF.js to new version 086a5921dc34dfd0e06dd994032dcf7e69305fe0 from 2023-11-20 17:53:35

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, enhancement)

Description

[Update Bot]

This update covers 3 commits. Here are the overall diff statistics, and then the commit information.

---

toolkit/components/pdfjs/content/build/pdf.mjs | 10 +++++-----
toolkit/components/pdfjs/content/build/pdf.scripting.mjs | 4 ++--
toolkit/components/pdfjs/content/build/pdf.worker.mjs | 9 ++++++---
toolkit/components/pdfjs/content/web/viewer-geckoview.mjs | 7 ++++---
toolkit/components/pdfjs/content/web/viewer.css | 2 +-
toolkit/components/pdfjs/content/web/viewer.mjs | 7 ++++---
toolkit/components/pdfjs/moz.yaml | 4 ++--
7 files changed, 24 insertions(+), 19 deletions(-)

---

a6f0609a6e40db3f8b741b19aacff354f9d4647b by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/a6f0609a6e40db3f8b741b19aacff354f9d4647b
Authored: 2023-11-20 17:33:49 +0100
Committed: 2023-11-20 17:33:49 +0100

Throw a JpegError when a JPEG image has no frame data (issue 17302)

Given that there's nothing to parse in this case, since we're dealing with an invalid JPEG image, throwing an explicit Error makes sense here.

Files Modified:

• src/core/jpg.js

---

bd6c2a192c4727b952976db90038f905ac9e0358 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/bd6c2a192c4727b952976db90038f905ac9e0358
Authored: 2023-11-20 13:22:02 +0100
Committed: 2023-11-20 13:22:02 +0100

[Editor] Make the alt-text button large enough to display correctly whatever string

Files Modified:

• web/annotation_editor_layer_builder.css

---

53101b379b3aa5986f0fa61b6cad9e3ecb8dc852 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/53101b379b3aa5986f0fa61b6cad9e3ecb8dc852
Authored: 2023-11-18 18:18:36 +0100
Committed: 2023-11-18 21:32:25 +0100

Restore the option to set light/dark mode for chromium and generic builds

Files Modified:

• extensions/chromium/preferences_schema.json
• gulpfile.mjs
• package-lock.json
• package.json
• web/app.js
• web/app_options.js

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=65795f59e28f0689824eeb2611b4d0d2572d5bd5

Comment 2

[Update Bot]

Attachment: Bug 1865691 - Update PDF.js to 086a5921dc34dfd0e06dd994032dcf7e69305fe0

Comment 3

[Update Bot]

All jobs completed, we found the following issues.

Known Issues (From Push Health):

• toolkit/components/pdfjs/test/browser_pdfjs_download_button.js
  • 1 of 4 failed on the same (retriggered) task
    - test-linux1804-64-qr/debug-mochitest-browser-chrome-spi-nw-1 (bJ8PJCwHRgqntgZ1-8Ey4Q)

Known Issues (From Taskcluster):

• test-linux1804-64-qr/debug-mochitest-browser-chrome-spi-nw-1 (bJ8PJCwHRgqntgZ1-8Ey4Q) - new failure not classified

Needs Investigation (Other Failed Jobs):

• test-windows11-64-2009-qr/debug-mochitest-plain-xorig-1
  • 1 of 1 failed on the same (retriggered) task (MUQeMPaZRluppFJd5GgHAA)
• test-windows11-64-2009-qr/debug-mochitest-browser-chrome-msix-1
  • 1 of 1 failed on the same (retriggered) task (SrMkIY-NSt2d81YpcpJYwQ)
• test-macosx1015-64-qr/debug-mochitest-plain-gpu
  • 1 of 1 failed on the same (retriggered) task (WY1FrSa4T26Pk1yB_-NsVg)
• test-windows11-64-2009-qr/debug-mochitest-browser-chrome-1
  • 1 of 1 failed on the same (retriggered) task (YIRRaUFxTYGoCP1HsPKxCA)
• test-macosx1015-64-qr/debug-test-verify
  • 1 of 1 failed on the same (retriggered) task (PzVFWzy7RJ-MQG70hfkczA)
• test-macosx1015-64-qr/debug-mochitest-plain-1
  • 1 of 1 failed on the same (retriggered) task (PYFHamW-Rly1dHIsfDBYUw)
• test-windows11-64-2009-qr/debug-mochitest-browser-chrome-swr-1
  • 1 of 1 failed on the same (retriggered) task (WX-2qvQWSH-0FAUaUdgd1w)
• test-macosx1015-64-qr/opt-mochitest-browser-chrome-spi-nw-1
  • 1 of 1 failed on the same (retriggered) task (U-D6qxlbRPigOJQFZgjwhg)
• test-macosx1015-64-qr/debug-test-verify-wpt
  • 1 of 1 failed on the same (retriggered) task (NA256w59RVe8xaT5GMMv1g)
• test-macosx1015-64-qr/opt-mochitest-browser-chrome-1
  • 1 of 1 failed on the same (retriggered) task (ZS9J_DvHQ2yut-9fRgHx2A)
• test-macosx1015-64-qr/debug-mochitest-plain-spi-nw-1
  • 1 of 1 failed on the same (retriggered) task (MroEpWN_QnSdGmkiYWx3bQ)
• test-windows11-32-2009-qr/debug-mochitest-plain-1
  • 1 of 1 failed on the same (retriggered) task (KM0frHLXS3y-a5VJZWkfpQ)
• test-linux2204-64-wayland/opt-mochitest-plain-1
  • 1 of 1 failed on the same (retriggered) task (DJ41h_IESCWpJOkbGLQ1qg)
• test-linux2204-64-wayland/debug-mochitest-plain-gpu
  • 1 of 1 failed on the same (retriggered) task (P7OCcofGRPyPQjkfJrvUAA)
• test-macosx1015-64-qr/debug-mochitest-plain-xorig-1
  • 1 of 1 failed on the same (retriggered) task (fVvmWEa-SS6Alsplunnslg)
• test-macosx1015-64-qr/opt-mochitest-plain-xorig-1
  • 1 of 1 failed on the same (retriggered) task (Pz70opPSTn6Ua91CqbCmmA)
• test-macosx1015-64-qr/debug-mochitest-browser-chrome-spi-nw-1
  • 1 of 1 failed on the same (retriggered) task (cxucCrLjR-2UOONJAl74Ag)
• test-macosx1015-64-qr/opt-mochitest-plain-gpu
  • 1 of 1 failed on the same (retriggered) task (JH0kMs5iSci-ri_Qbvy-Jg)
• test-macosx1015-64-qr/opt-mochitest-plain-1
  • 1 of 1 failed on the same (retriggered) task (RhLD35o8QpqZHkijIXWRUQ)
• test-macosx1015-64-qr/opt-test-verify
  • 1 of 1 failed on the same (retriggered) task (FX0v_0eASYGhhc4nSjUCAg)
• test-linux1804-64-shippable-qr/opt-mochitest-plain-headless-1
  • 1 of 1 failed on the same (retriggered) task (NPujve0vRPSzEYwyQEbJ7g)
• test-linux1804-64-shippable-qr/opt-mochitest-plain-headless-spi-nw-1
  • 1 of 1 failed on the same (retriggered) task (Rb-cwYOBQz6-tDs3tFWMQQ)
• test-windows11-64-2009-qr/debug-mochitest-browser-chrome-spi-nw-1
  • 1 of 1 failed on the same (retriggered) task (ed-8FtgFRq2E8Ppg2HZGHg)
• test-macosx1015-64-qr/opt-mochitest-devtools-chrome-1
  • 1 of 1 failed on the same (retriggered) task (awOx7qZnSU2iqoashqUe8Q)
• test-macosx1015-64-qr/opt-test-verify-wpt
  • 1 of 1 failed on the same (retriggered) task (CGBIT_vcSHSxaJpwjPcrgg)
• test-macosx1015-64-qr/opt-mochitest-plain-spi-nw-1
  • 1 of 1 failed on the same (retriggered) task (aGgD_txxQ4W8VarSJ09Czg)
• test-macosx1015-64-qr/debug-mochitest-browser-chrome-1
  • 1 of 1 failed on the same (retriggered) task (cFnLQOOoRoaa9DR5Te2ylw)
• test-macosx1015-64-qr/opt-mochitest-devtools-chrome-spi-nw-1
  • 1 of 1 failed on the same (retriggered) task (ADTRvHwfTEm2TlhyMt6TUw)
• test-linux2204-64-wayland/debug-mochitest-plain-1
  • 1 of 1 failed on the same (retriggered) task (Ph_HmAEPTXaosYQHNrpo2w)
• test-windows11-32-2009-qr/debug-test-verify
  • 1 of 1 failed on the same (retriggered) task (DzTruVLMRqyWVNfMMDj-bg)
• test-windows11-64-2009-qr/opt-mochitest-plain-1
  • 1 of 1 failed on the same (retriggered) task (X7hyeCS8SQW9kW8aRk5Ypg)
• test-windows11-64-2009-qr/opt-mochitest-plain-xorig-1
  • 1 of 1 failed on the same (retriggered) task (W2fOC3JKT56nlMO3CsRKdA)
• test-windows11-64-2009-qr/opt-mochitest-plain-spi-nw-1
  • 1 of 1 failed on the same (retriggered) task (VO2Aqcy4QsmMyBeWbn5UVA)
• test-windows11-64-2009-qr/opt-test-verify
  • 1 of 1 failed on the same (retriggered) task (Te-GYLwsRQeISK475QI05w)
• test-windows11-32-2009-qr/debug-mochitest-plain-xorig-1
  • 1 of 1 failed on the same (retriggered) task (GOZ66QIwTqi07dKChf2-Eg)
• test-windows11-64-2009-qr/opt-test-verify-wpt
  • 1 of 1 failed on the same (retriggered) task (dam2nxD4RAmQVfq7Atzlvw)
• test-windows11-64-2009-qr/opt-mochitest-browser-chrome-spi-nw-1
  • 1 of 1 failed on the same (retriggered) task (LnUF0gUcQWO-tB2o3BggLg)
• test-windows11-64-2009-qr/debug-test-verify-wpt
  • 1 of 1 failed on the same (retriggered) task (NDrWB34jQ7uKsNBz6jyllA)
• test-windows11-64-2009-qr/opt-mochitest-browser-chrome-1
  • 1 of 1 failed on the same (retriggered) task (QyJd4W2lTHGxmolPHeoIxA)
• test-windows11-64-2009-qr/debug-mochitest-plain-1
  • 1 of 1 failed on the same (retriggered) task (Hl4bs_SMSTOh_xHM0MtGZQ)
• test-windows11-64-2009-qr/opt-mochitest-devtools-chrome-1
  • 1 of 1 failed on the same (retriggered) task (BvG8sjXBQlq2b0XSFD4JCQ)
• test-windows11-32-2009-qr/opt-test-verify-wpt
  • 1 of 1 failed on the same (retriggered) task (FdEg4fUuSP-6xwu-K_luXg)
• test-windows11-32-2009-qr/opt-mochitest-plain-1
  • 1 of 1 failed on the same (retriggered) task (H20W4nDKT3W0Icg_bXhoEg)
• test-windows11-32-2009-qr/debug-test-verify-wpt
  • 1 of 1 failed on the same (retriggered) task (LL8QN0W-RW-QfVGrBiO3gA)
• test-windows11-64-2009-qr/opt-mochitest-devtools-chrome-spi-nw-1
  • 1 of 1 failed on the same (retriggered) task (a08A8QchSfGPvWFWvrInNg)
• test-windows11-32-2009-qr/opt-mochitest-plain-xorig-1
  • 1 of 1 failed on the same (retriggered) task (HUWqNu3JQmKERukorjaHmg)
• test-windows11-32-2009-qr/opt-mochitest-browser-chrome-1
  • 1 of 1 failed on the same (retriggered) task (IgN82pnYTlKn-igebY846g)
• test-windows11-32-2009-qr/opt-test-verify
  • 1 of 1 failed on the same (retriggered) task (Cmj0SsTiTNOL9ZoPXYaDBA)
• test-windows11-64-2009-qr/opt-mochitest-browser-chrome-msix-1
  • 1 of 1 failed on the same (retriggered) task (bdJ5EhreSOKIkGMEBl_-bA)
• test-windows11-64-2009-qr/debug-test-verify
  • 1 of 1 failed on the same (retriggered) task (VIq8jiFTTHy_TFfdaeY8bg)
• test-linux2204-64-wayland/opt-mochitest-plain-gpu
  • 1 of 1 failed on the same (retriggered) task (ReFl3u6hTLKCUKHnmv243g)
• test-windows11-64-2009-qr/debug-mochitest-plain-spi-nw-1
  • 1 of 1 failed on the same (retriggered) task (Ay7D6cvjRuOjDCOOMiTDsg)
• test-windows11-32-2009-qr/debug-mochitest-browser-chrome-1
  • 1 of 1 failed on the same (retriggered) task (Ib_QA5dOSnKXzz_fyHo5pQ)

These failures may mean that the library update succeeded; you'll need to review
them yourself and decide. If there are lint failures, you will need to fix them in
a follow-up patch. (Or ignore the patch I made, and recreate it yourself with
./mach vendor toolkit/components/pdfjs/moz.yaml.)

In either event, I have done all I can, so you will need to take it from here.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db45f9329c96
Update PDF.js to 086a5921dc34dfd0e06dd994032dcf7e69305fe0 r=pdfjs-reviewers,calixte

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/db45f9329c96