Closed Bug 1865727 Opened 2 years ago Closed 2 years ago

GeckoView API to Change Site Translation Option Independent of Session

Categories

(Firefox for Android :: Translations, enhancement, P1)

All
Android
enhancement

Tracking

()

RESOLVED FIXED
122 Branch
Tracking Status
firefox120 --- wontfix
firefox121 --- wontfix
firefox122 --- fixed

People

(Reporter: olivia, Assigned: olivia)

References

Details

(Whiteboard: [fxdroid][foundation][geckoview:m122])

Attachments

(1 file)

We need to add an additional Runtime API to remove never translate sites independent of session.

We currently have:

setNeverTranslateSiteSetting
getNeverTranslateSiteSetting

for the current session.

However, we also need runtime support that accept a parameter of (site) for managing them from the settings page too.

Severity: -- → N/A
Priority: -- → P2
Whiteboard: [fxdroid][foundation]

Need to also add a query to make this page. Will investigate how difficult this getting this list is. Ideally would be on this patch too since they would need to work together.

Assignee: nobody → ohall
Priority: P2 → P1
Whiteboard: [fxdroid][foundation] → [fxdroid][foundation][geckoview:m122]

This patch adds an option for GeckoView to change site settings outside
of the session. These APIs should be used for global modifications to
the "never translate these sites" list.

Additionally, this patch moves some Desktop translations logic to the
toolkit for shared use.

Blocks: 1862288
Pushed by ohall@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/39bb28c0ba24 GeckoView Runtime Never Translate Site Option r=geckoview-reviewers,settings-reviewers,translations-reviewers,gregtatum,owlish,boek
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: