1865736 - Firefox.exe missing after update, out of disk space can cause the updates are incomplete?

Status: NEW

(Toolkit :: Application Update, defect, P3)

Description

[Max Christian Pohle [:/dev/max]]

Attachment: update-elevated.log

I updated my Nightly from Fx120 to Fx121 manually today. In the menu I first clicked on download and after some time on update and restart. But the browser was not opened again and the icon for Nightly changed on my desktop.

After it did not start I tried to start manually using this 'broken' icon and it triggered the Windows dialog 'missing shortcut'. I investigated further and found, that the C:\Program Files\Firefox Nightly folder was incomplete and did not contain a firefox.exe any more.

I wanted to know how that happened and investigated further.

The update.log contains:

2023-11-20 12:49:17+0100: Launching service failed. useService=false
2023-11-20 12:49:17+0100: Elevating via a UAC prompt
2023-11-20 12:49:17+0100: Writing status to file: failed: 79

2023-11-20 12:49:19+0100: Elevation successful. Waiting for elevated updater to run.
2023-11-20 12:49:23+0100: Elevated updater has finished running.
2023-11-20 12:49:23+0100: CompareSecureUpdateStatus failed: 70
 does not match succeeded
2023-11-20 12:49:23+0100: Not running LaunchWinPostProcess because update status is not'succeeded'.
2023-11-20 12:49:23+0100: Update complete

and I am attaching the update-elevated.log for its length. It has this line noteworthy

2023-11-20 12:49:23+0100: EXECUTE ADD browser/omni.ja
2023-11-20 12:49:23+0100: ### execution failed
2023-11-20 12:49:23+0100: FINISH REMOVEFILE xul.dll.sig
[...] more REMOVEFILE

and then tries to restore files from a backup file, which does not exist, e.g.

2023-11-20 12:49:23+0100: FINISH ADD firefox.exe
2023-11-20 12:49:23+0100: backup_restore: backup file doesn't exist: firefox.exe.moz-backup

before its fails with

2023-11-20 12:49:23+0100: failed: 70
2023-11-20 12:49:23+0100: Writing status to file: failed: 70

which (I believe) means WRITE_ERROR_EXTRACT and is printed here.

Because a large update was automatically performed simultaneously and without my knowledge, it is possible that I ran out of disk space, because have ~3GB free. However I believe it should nevertheless leave the installation folder in some usable state.