1865830 - Implement CommandEncoder.clearTexture

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, task, P3)

Description

[Nicolas Silva [:nical]]

We are currently missing this part of the API.

covered by _mozilla/webgpu/chunked/2/cts.https.html?q=webgpu:api,operation,command_buffer,clearBuffer:clear:*

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1865830 - Implement CommandEncoder.clearBuffer. r=#webgpu-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/774b13e9f1e7
Implement CommandEncoder.clearBuffer. r=webgpu-reviewers,webidl,emilio,ErichDonGubler

Comment 3

[Iulian Moraru]

Backed out for causing mass build bustages.

• Push with failures

• Failure log

• Backout link

[task 2023-12-04T23:12:15.804Z] 23:12:15     INFO -       Running `CARGO=/builds/worker/fetches/rustc/bin/cargo CARGO_CRATE_NAME=webrender CARGO_MANIFEST_DIR=/builds/worker/checkouts/gecko/gfx/wr/webrender CARGO_PKG_AUTHORS='Glenn Watson <[e-mail]>' CARGO_PKG_DESCRIPTION='A GPU accelerated 2D renderer for web content' CARGO_PKG_HOMEPAGE='' CARGO_PKG_LICENSE=MPL-2.0 CARGO_PKG_LICENSE_FILE='' CARGO_PKG_NAME=webrender CARGO_PKG_README='' CARGO_PKG_REPOSITORY='https://github.com/servo/webrender' CARGO_PKG_RUST_VERSION='' CARGO_PKG_VERSION=0.62.0 CARGO_PKG_VERSION_MAJOR=0 CARGO_PKG_VERSION_MINOR=62 CARGO_PKG_VERSION_PATCH=0 CARGO_PKG_VERSION_PRE='' LD_LIBRARY_PATH='/builds/worker/workspace/obj-build/release/deps:/builds/worker/fetches/rustc/lib:/builds/worker/fetches/clang/lib' OUT_DIR=/builds/worker/workspace/obj-build/x86_64-linux-android/release/build/webrender-a20bd993c0d1c952/out /builds/worker/fetches/sccache/sccache /builds/worker/fetches/rustc/bin/rustc --crate-name webrender --edition=2018 gfx/wr/webrender/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=2 -C panic=abort -C embed-bitcode=no --cfg 'feature="capture"' --cfg 'feature="firefox-on-glean"' --cfg 'feature="gecko"' --cfg 'feature="ron"' --cfg 'feature="serde"' --cfg 'feature="serialize_program"' --cfg 'feature="sw_compositor"' --cfg 'feature="swgl"' -C metadata=0b490d9f3935f39d -C extra-filename=-0b490d9f3935f39d --out-dir /builds/worker/workspace/obj-build/x86_64-linux-android/release/deps --target x86_64-linux-android -C linker=/builds/worker/checkouts/gecko/build/cargo-linker -L dependency=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps -L dependency=/builds/worker/workspace/obj-build/release/deps --extern bincode=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libbincode-8f366a730f7fe652.rmeta --extern bitflags=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libbitflags-860d90b3e3d7c8ac.rmeta --extern byteorder=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libbyteorder-277169a31f126165.rmeta --extern derive_more=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libderive_more-4d816e9740174739.rmeta --extern etagere=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libetagere-41062053fcd709bf.rmeta --extern euclid=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libeuclid-6a5a01740f0c2ec9.rmeta --extern firefox_on_glean=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libfirefox_on_glean-8b7db7e664e64907.rmeta --extern fxhash=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libfxhash-17271638756a008f.rmeta --extern gleam=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libgleam-3edde05c308db72d.rmeta --extern glean=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libglean-bb7688e8e96e44c2.rmeta --extern lazy_static=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/liblazy_static-0a298ed8a32702a8.rmeta --extern log=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/liblog-640b297c6ad74432.rmeta --extern malloc_size_of_derive=/builds/worker/workspace/obj-build/release/deps/libmalloc_size_of_derive-20e126718aab9c15.so --extern num_traits=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libnum_traits-8471ecccb6cc4b19.rmeta --extern peek_poke=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libpeek_poke-1d0d1f85781b1354.rmeta --extern plane_split=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libplane_split-7f09e70044085b1a.rmeta --extern rayon=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/librayon-c95a1efd37d0e8e1.rmeta --extern ron=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libron-cc2b968cd2c63ec9.rmeta --extern serde=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libserde-d6542ff1dc1f29fa.rmeta --extern smallvec=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libsmallvec-d4d6da7462799e8c.rmeta --extern svg_fmt=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libsvg_fmt-67b306210c4c3606.rmeta --extern swgl=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libswgl-48ce7b77d7f453bc.rmeta --extern time=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libtime-f492ac0a829eec6d.rmeta --extern topological_sort=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libtopological_sort-c8c15510afe6110f.rmeta --extern tracy_rs=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libtracy_rs-b1ef85ac515df951.rmeta --extern api=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libwebrender_api-2be3b7017376e34b.rmeta --extern webrender_build=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libwebrender_build-ad04359efee5640f.rmeta --extern glyph_rasterizer=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libwr_glyph_rasterizer-0d37e538c34832df.rmeta --extern malloc_size_of=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libwr_malloc_size_of-c9b918290dcfc04e.rmeta -C debuginfo=2 -C force-frame-pointers=yes -Dwarnings -Aproc-macro-back-compat -Cembed-bitcode=yes -C codegen-units=1 -L native=/builds/worker/workspace/obj-build/x86_64-linux-android/release/build/lmdb-rkv-sys-2cef7222d0e1233c/out -L native=/builds/worker/workspace/obj-build/x86_64-linux-android/release/build/swgl-f7abddd0bcf0f8e0/out`
[task 2023-12-04T23:12:15.804Z] 23:12:15    ERROR -  error[E0308]: mismatched types
[task 2023-12-04T23:12:15.805Z] 23:12:15     INFO -      --> gfx/wgpu_bindings/src/client.rs:1283:15
[task 2023-12-04T23:12:15.805Z] 23:12:15     INFO -       |
[task 2023-12-04T23:12:15.805Z] 23:12:15     INFO -  1283 |         size: size.cloned(),
[task 2023-12-04T23:12:15.806Z] 23:12:15     INFO -       |               ^^^^^^^^^^^^^ expected `Option<NonZeroU64>`, found `Option<u64>`
[task 2023-12-04T23:12:15.806Z] 23:12:15     INFO -       |
[task 2023-12-04T23:12:15.806Z] 23:12:15     INFO -       = note: expected enum `std::option::Option<NonZeroU64>`
[task 2023-12-04T23:12:15.806Z] 23:12:15     INFO -                  found enum `std::option::Option<u64>`
[task 2023-12-04T23:12:15.807Z] 23:12:15     INFO -  For more information about this error, try `rustc --explain E0308`.
[task 2023-12-04T23:12:15.807Z] 23:12:15     INFO -  error: could not compile `wgpu_bindings` (lib) due to previous error
[task 2023-12-04T23:12:15.807Z] 23:12:15     INFO -  Caused by:
[task 2023-12-04T23:12:15.810Z] 23:12:15     INFO -    process didn't exit successfully: `CARGO=/builds/worker/fetches/rustc/bin/cargo CARGO_CRATE_NAME=wgpu_bindings CARGO_MANIFEST_DIR=/builds/worker/checkouts/gecko/gfx/wgpu_bindings CARGO_PKG_AUTHORS='Dzmitry Malyshau <[e-mail]>:Joshua Groves <[e-mail]>' CARGO_PKG_DESCRIPTION='' CARGO_PKG_HOMEPAGE='' CARGO_PKG_LICENSE=MPL-2.0 CARGO_PKG_LICENSE_FILE='' CARGO_PKG_NAME=wgpu_bindings CARGO_PKG_README='' CARGO_PKG_REPOSITORY='' CARGO_PKG_RUST_VERSION='' CARGO_PKG_VERSION=0.1.0 CARGO_PKG_VERSION_MAJOR=0 CARGO_PKG_VERSION_MINOR=1 CARGO_PKG_VERSION_PATCH=0 CARGO_PKG_VERSION_PRE='' LD_LIBRARY_PATH='/builds/worker/workspace/obj-build/release/deps:/builds/worker/fetches/rustc/lib:/builds/worker/fetches/clang/lib' /builds/worker/fetches/sccache/sccache /builds/worker/fetches/rustc/bin/rustc --crate-name wgpu_bindings --edition=2018 gfx/wgpu_bindings/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C opt-level=2 -C panic=abort -C embed-bitcode=no --cfg 'feature="default"' -C metadata=15275b9e7a0c2aaa -C extra-filename=-15275b9e7a0c2aaa --out-dir /builds/worker/workspace/obj-build/x86_64-linux-android/release/deps --target x86_64-linux-android -C linker=/builds/worker/checkouts/gecko/build/cargo-linker -L dependency=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps -L dependency=/builds/worker/workspace/obj-build/release/deps --extern bincode=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libbincode-8f366a730f7fe652.rmeta --extern log=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/liblog-640b297c6ad74432.rmeta --extern nsstring=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libnsstring-abd54764ace5b211.rmeta --extern parking_lot=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libparking_lot-cf4287a38510b6b6.rmeta --extern serde=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libserde-d6542ff1dc1f29fa.rmeta --extern static_prefs=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libstatic_prefs-d5155daf7b3f1fe5.rmeta --extern wgc=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libwgpu_core-e7d2b2e3be49af0e.rmeta --extern wgh=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libwgpu_hal-f556676bfd6784aa.rmeta --extern wgt=/builds/worker/workspace/obj-build/x86_64-linux-android/release/deps/libwgpu_types-f95e981f1de2b3c8.rmeta -C debuginfo=2 -C force-frame-pointers=yes -Dwarnings -Aproc-macro-back-compat -Cembed-bitcode=yes -C codegen-units=1` (exit status: 1)
[task 2023-12-04T23:12:15.810Z] 23:12:15     INFO -  warning: build failed, waiting for other jobs to finish...
[task 2023-12-04T23:12:15.810Z] 23:12:15    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/makefiles/rust.mk:490: force-cargo-library-build] Error 101
[task 2023-12-04T23:12:15.810Z] 23:12:15     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/library/rust'
[task 2023-12-04T23:12:15.811Z] 23:12:15     INFO -  gmake[4]: Target 'target-objects' not remade because of errors.
[task 2023-12-04T23:12:15.811Z] 23:12:15    ERROR -  gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: toolkit/library/rust/target-objects] Error 2
[task 2023-12-04T23:12:15.811Z] 23:12:15     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/config/external/icu/i18n'

Comment 4

[Nicolas Silva [:nical]]

I should have landed it on top of bug 1868143

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c57ecb4b95f
Implement CommandEncoder.clearBuffer. r=webgpu-reviewers,webidl,emilio,ErichDonGubler

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8c57ecb4b95f