1865958 - Refactor tests in toolkit/content/tests/chrome/test_notificationbox.xhtml

Status: NEW

(Toolkit :: PopupNotifications and Notification Bars, task)

Description

[Hanna Jones [:hjones]]

The tests in toolkit/content/tests/chrome/test_notificationbox.xhtml aren't using the most up to date syntax / testing patterns. Right now we do some kind of convoluted work where we create an array of test objects that we run by passing them to a runTimedTests function. We could clean this up by using add_test instead of an array of tests + adding methods for creating and removing notifications instead of using the existing test and result mechanics, which aren't common to other Firefox tests.

Comment 1

[Meg Viar [:mviar]]

Additionally, we can add coverage for the logic added in bug 1958972. That patch added automated testing in browser/components/asrouter/tests/browser/browser_asrouter_infobar.js, but would be good to cover in toolkit/content/tests/chrome/test_notificationbox.xhtml as well.