1866069 - The title and the text description from the "Opt-In" section cannot be accessed by a screen reader software on macOS and Linux

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

[Affected versions]:

• Firefox Beta 121.0b1 - Build ID: 20231120154937
• Firefox Nightly 122.0a1 - Build ID: 20231122095244

[Affected Platforms]:

• macOS 13.1
• Ubuntu 22.04 x64

[Prerequisites]:

• Have a Screen Reader software installed and enabled (I have used VoiceOver on macOS and Orca on Ubuntu 22.04).
• Have a Firefox profile with the following prefs in the "about:config" page:
  • browser.urlbar.quicksuggest.contextualOptIn set to true
  • browser.search.region set to US

[Steps to reproduce]:

1. Open the browser using the profile from the prerequisites.
2. Open a New Tab and click the "Address Bar".
3. Navigate through the "Address Bar" dropdown and observe the behavior.

[Expected result]:

• All the elements from the "Opt-In" section are successfully recognized by the screen reader software.

[Actual result]:

• Only the buttons and the "Learn more" hyperlink from the "Opt-In" section are recognized by the screen reader software.

[Notes]:

• This issue is reproducible regardless if the "Opt-In" section is displayed at the top or at the bottom of the "Address Bar" doorhanger.
• This issue is not reproducible on Windows 10 x64 with the built-in screen reader (Narrator). All the elements are correctly recognized by the screen reader if the "Opt-In" section is displayed at the top of the “Address Bar” doorhanger. However, the "Opt-In" section cannot be accessed through the screen reader software if the section is displayed in the bottom part of the doorhanger.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1866069 - Announce title and description on the contextual opt-in row when selecting the first element (i.e. the learn more link). r=daleharvey

This is a hack for the experiment and likely not ideal for screen readers, but better than what we have. I'm reaching out to a11y folks to figure out the right long-term solution here. I'll make an effort to get that ready for the experiment too, but would like to get this landed as a backup.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a9dc4e73f46
Announce title and description on the contextual opt-in row when selecting the first element (i.e. the learn more link). r=daleharvey

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 9365173 [details]
Bug 1866069 - Announce title and description on the contextual opt-in row when selecting the first element (i.e. the learn more link). r=daleharvey

Beta/Release Uplift Approval Request

• User impact if declined: this is needed for a Firefox Suggest experiment that we're running in 121, supports OKR 5.2
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: QA has the steps, they filed this bug :)
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): limited to experiment code
• String changes made/needed:
• Is Android affected?: No

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5a9dc4e73f46

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9365173 [details]
Bug 1866069 - Announce title and description on the contextual opt-in row when selecting the first element (i.e. the learn more link). r=daleharvey

Approved for 121.0b5.

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/f8c266960a43

Comment 7

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified the issue on the latest Beta 121.0b5 (Build ID: 20231129091815) and on the latest Nightly 122.0a1 (Build ID: 20231129050021) on Windows 10 x64, macOS 13.1 and Linux Mint 20.1 x64.

• The title and the text are correctly recognized by the screen reader on Linux, but on macOS the issue is still reproducible. I have logged a separate issue for macOS in Bug 1867309.

Also, it seems that this fix caused a new regression. The focus remains stuck the entire Firefox session after focusing any of the buttons from the Search OneOffs section while the Opt-In section is displayed at the bottom. I have logged it in Bug 1867308.

Considering this, I will mark this issue as Verified-Fixed and we will track the other two issues in separate bugs.