1866120 - The webcompat reporter's confirmation screen is not readable in some combinations of High Contrast and Browser Themes on Windows

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Daniel Bodea [:danibodea]]

Found in

• Beta v121.0b1

Affected versions

• Nightly v121.0a1
• Beta v121.0b1

Tested platforms

• Affected platforms: Windows 10
• Unaffected platforms: MacOS, Ubuntu

Steps to reproduce

1. Make sure new webcopmpat feature is enabled:
   ui.new-webcompat-reporter.enabled = true
2. Enable High Contrast White in Windows
3. Enable the Dark Theme in Firefox
4. Load any webpage
5. Go to Hamburger Menu / Report broken site
6. Sent a report and observe the confirmation screen.

Expected result

• The confirmation screen is properly displayed.

Actual result

• The text color contrast is incorrect and unreadable.

Regression range

• not a regression, but an implementation flaw.

Additional information

• The combinations of faulty behaviors:

1. HC-White + AlpenglowTheme
2. HC-White + Dark Theme
3. HC-Black + Light Theme

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:danibodea, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Daniel Bodea [:danibodea]]

Attachment: HC vs theme.png

Comment 4

[Anna Yeddi [:ayeddi]]

Marking it as access-s2 since the text would not be accessible for HCM users.

Using CanvasText for the foreground color and Canvas for the background for text, and ButtonText and ButtonFace color combination in prefers-contrast query could resolve the issue. Refer to the HCM playground (NDA'ed link) for examples of expected view on Windows 10 and 11 with different HCM themes on

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:mossop, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 6

[OOO until Apr 20; Dan Mosedale (:dmosedale, :dmose)]

Thomas, itiel, if either of you are available to get to this soon enough, we could consider requesting an uplift.

Comment 7

[Thomas Wisniewski [:twisniewski]]

It's next on my docket. I was hoping to get a patch together tomorrow, but we'll see.

Comment 8

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1866120 - do not use color-background-success for the Report Broken Site confirmation screen if @media(prefers-contrast); r?gijs

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb86f35848f6
do not use color-background-success for the Report Broken Site confirmation screen if @media(prefers-contrast); r=Gijs,desktop-theme-reviewers,Itiel

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/bb86f35848f6

Comment 11

[Daniel Bodea [:danibodea]]

This fix has been verified in Nightly v122.0a1 from 2023-12-06. Branch 121 is not fixed.

Comment 12

[Thomas Wisniewski [:twisniewski]]

Comment on attachment 9367048 [details]
Bug 1866120 - do not use color-background-success for the Report Broken Site confirmation screen if @media(prefers-contrast); r?gijs

Beta/Release Uplift Approval Request

• User impact if declined: Users with certain high contrast configurations may not be able to see some the text on the Report Broken Site feature's confirmation dialog.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The Report Broken Site feature is not enabled by default in 121.
• String changes made/needed:
• Is Android affected?: No

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9367048 [details]
Bug 1866120 - do not use color-background-success for the Report Broken Site confirmation screen if @media(prefers-contrast); r?gijs

Approved for 121.0b9.

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/68ccd338dab1

Comment 15

[Daniel Bodea [:danibodea]]

I have verified this fix in Beta v121.0b9 taken from treeherder. COnfirmation message is now readable in the mentioned combinatins of theme and screen reader.