1866142 - The "Send more info" link from the new webcompat reporter tool is not accessible by keyboard navigation

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Daniel Bodea [:danibodea]]

Found in

• Beta v121.0b1

Affected versions

• Nightly v122.0a1
• Beta v121.0b2

Tested platforms

• Affected platforms: Windows 10, MacOS, Ubuntu 22
• Unaffected platforms: ?

Steps to reproduce

1. Flip:
   ui.new-webcompat-reporter.enabled = TRUE
   ui.new-webcompat-reporter.send-more-info-link = true
2. Load any webpage.
3. Open the webcompat reporter tool
4. Use keyboard navigation to reach and access the "Send more info" link

Expected result

• The link is reachable and accessible by Enter/Space key.

Actual result

• The link is reachable, but NOT accessible by Enter/Space key.

Regression range

• Not a regression but a flaw of implementation.

Additional notes

• This issue occurs without the use of a screen reader and also reproduces when using the JAWS screen reader, but it does not occur when running the NVDA screen reader.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:danibodea, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1866142 - allow the enter key to activate the send more info button on Report Broken Site; r?gijs

• Drop the href from the anchor, otherwise when the tab is closed, the entire window goes with (preventDefault doesn't help)
• Use event.target instead of event.view, which is not defined for the related key events.
• Add tests for keyboard navigation, and improve the Help menu support code for tests.

Comment 3

[Anna Yeddi [:ayeddi]]

marking as access-s2 because the current behavior creates a barrier for keyboard-only users without screen readers and users with JAWS

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa34b45b5cda
allow the enter key to activate the send more info button on Report Broken Site; r=Gijs

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures on browser_keyboard_navigation.js

Backout link

Push with failures

Failure log

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:twisniewski, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/227f510e4c43
allow the enter key to activate the send more info button on Report Broken Site; r=Gijs

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Disability Access APIs' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 9

[Anna Yeddi [:ayeddi]]

Returning the bug to the appropriate component

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/227f510e4c43

Comment 11

[Thomas Wisniewski [:twisniewski]]

Comment on attachment 9365267 [details]
Bug 1866142 - allow the enter key to activate the send more info button on Report Broken Site; r?gijs

Beta/Release Uplift Approval Request

• User impact if declined: The "send more info" link on the new Report Broken Site feature will not activate using keyboard controls. Also, this is a precursor for another uplift we intend to do soon (bug 1865815).
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: 1. In about:config, ensure that ui.new-webcompat-reporter.enabled is set to true (ui.new-webcompat-reporter.send-more-info-link should be true as well, which is the default for beta channel).

2. Visit any regular webpage.
3. Access the Report Broken Site feature (ie, Help menu or App menu -> Report Broken Site).
4. Repeatedly press the tab key until "send more info" is focused, and then press Enter.
5. Confirm that a new tab opens to webcompat.com upon pressing Enter (if nothing happens, the bug is still present).

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This only affects the new Report Broken Site feature, which is disabled by default (and will only be run as a limited-audience experiment during the 121 cycle).
• String changes made/needed:
• Is Android affected?: No

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9365267 [details]
Bug 1866142 - allow the enter key to activate the send more info button on Report Broken Site; r?gijs

Approved for 121.0b6.

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/e97bd51dc597

Comment 14

[Daniel Bodea [:danibodea]]

I have verified this fix in Nightly v122.0a1 and Beta v121.0b6 in:

• Win 10 without a screen reader enabled
• Win 10 with JAWS
• Win 10 with NVDA
• MacOS 11 without a screen reader enabled
• Ubuntu 22 without a screen reader enabled

The "Send more info" link is now accessible by keyboard navigation, with and without a screen reader enabled.