1866309 - Add/modify herald rules to exclude taskgraph-reviewers from certain files

Status: RESOLVED FIXED

(Conduit :: Administration, task)

Description

[Greg Mierzwinski [:sparky]]

There are some files that are owned by the perftest team which we don't think require taskgraph-reviewers to be added. We'd like to add/modify the herald rule to exclude the following files/folders from the taskgraph-reviewers group:

taskcluster/ci/perftest
taskcluster/gecko_taskgraph/transforms/perftest.py
taskcluster/gecko_taskgraph/transforms/test/raptor.py

If possible, it would be good to have the reviewer group removed for these task definition files as well:

taskcluster/ci/test/browsertime-desktop.yml
taskcluster/ci/test/browsertime-mobile.yml
taskcluster/ci/test/talos.yml
taskcluster/ci/test/awsy.yml

:ahal, what do you think about these?

Comment 1

[Andrew Halberstadt [:ahal]]

Yep, that looks good to me!

We might want to make sure #perftest-reviewers is flagged for those instead, but I'll leave that up to Greg. I heard it's possible to have two Herald regexes AND'ed together, so hopefully this isn't too hard to implement.

Comment 2

[Greg Mierzwinski [:sparky]]

Ah yes please, thanks for mentioning that! If we could add #perftest-reviewers to those files that would be great.

Comment 3

[David Lawrence [:dkl]]

All done
https://phabricator.services.mozilla.com/H390
https://phabricator.services.mozilla.com/H413

Comment 4

[Greg Mierzwinski [:sparky]]

Thanks a lot for taking care of this :dkl!