Closed Bug 1866403 Opened 1 year ago Closed 1 year ago

Nov24 Windows Bustage: Intermittent lld-link: error: undefined symbol: __declspec(dllimport) _PropVariantToString@12

Categories

(Thunderbird :: Upstream Synchronization, defect, P5)

Tracking

(thunderbird_esr115 unaffected)

RESOLVED FIXED
122 Branch
Tracking Status
thunderbird_esr115 --- unaffected

People

(Reporter: intermittent-bug-filer, Assigned: mkmelin)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Summary: Nov24 Bustage: Intermittent lld-link: error: undefined symbol: __declspec(dllimport) _PropVariantToString@12 → Nov24 Windows Bustage: Intermittent lld-link: error: undefined symbol: __declspec(dllimport) _PropVariantToString@12

Apparently from bug 1529276 since that added TestJumpListBuilder.cpp where the build fails

Keywords: regression
Regressed by: 1529276

(In reply to Magnus Melin [:mkmelin] from comment #3)

PropVariantToString is from https://searchfox.org/comm-central/source/mozilla/third_party/WinToast/wintoastlib.cpp#64

PropVariantToString is a win32 function:
https://learn.microsoft.com/en-us/windows/win32/api/propvarutil/nf-propvarutil-propvarianttostring
WinToast appears to be using it, so does TestJumpListBuilder.cpp.

Looks like the TB build is missing Propsys.lib during linking (or something similar).

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/07b121b1f4d8
Windows needs propsys. rs=bustage-fix

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Assignee: nobody → mkmelin+mozilla
Target Milestone: --- → 122 Branch
You need to log in before you can comment on or make changes to this bug.